58698 - Solaris only: cmd_cut operation fails in optimize build

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Masaki Katakai]

I can not delete one line or multiple selection on Mail Composer (TextEdit mode)
on Solaris optimize build. Please try the following operations,

1) Start Mozilla Mail
2) Set TextEdit mode
3) Select a message
4) Reply
5) On Compose window, make a selection for one line by double click
6) Press Back Space

I expect the line is deleted. However, it fails on only Solaris build.
I never seen on Linux and Windows.

It seems that DeleteRangeTxn.cpp in editor/base/src does not
initialize nsresult result. It works in debug build, however,
it fails in optimize build on Solaris.

Due to this problem, "cmd_cut" operation fails on Solaris as well.
It's serious.

Please try the patch. I'll attach the simple patch.

Comment 1

[Masaki Katakai]

Attachment: patch that assign NS_OK to result

Comment 2

[Rich Burridge]

Assigning to kin, who knows about this problem. Thanks!

Comment 3

[kinmoz]

r=[e-mail]  and sr=[e-mail] on the 10/31/00 21:52 patch.

I'll probably check this into the Trunk for [e-mail] tomorrow morning.

Comment 4

[kinmoz]

Fix from [e-mail], checked into Trunk:

    mozilla/editor/base/DeleteRangeTxn.cpp  revision 1.54

This bug still exists on the Netscape_20000922_BRANCH.

Comment 5

[sujay]

KAtakai, please verify this bug and mark VERIFIED-FIXED...thanks!

Comment 6

[Masaki Katakai]

Thank you very much for integration. I'll verify on Monday.

Comment 7

[sujay]

KAtakai please mark verified-fixed...thanks.

Comment 8

[Masaki Katakai]

Sorry for late. I've verified the fix on 2000111509 Solaris build.
Thank you for fix! Please mark it as VERIFIED.

Comment 9

[sujay]

marking verified

Comment 10

[Margaret Chan]

The same fix has been applied to the OEM branch:  Netscape_6_0_OEM_BRANCH.
a=[e-mail].