587103 - AIX: 6 source files fail to compile in xlC due to template/static inline scoping

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Paprocki]

Attachment: jstypedarray.diff

TypedArrayTemplate is (obviously) a template, and it is referencing INT_TO_JSVAL, a static inline function, without prefixing it with "::". This breaks xlC because it can not resolve INT_TO_JSVAL. The standard does not require that statics be considered if the unqualified name is not found in the context of the template arguments. g++ does this fallback, xlC does not.

Comment 1

[Andrew Paprocki]

Example error:
"jstypedarray.cpp", line 545.19: 1540-0274 (S) The name lookup for
"INT_TO_JSVAL" did not find a declaration.
"jstypedarray.cpp", line 545.19: 1540-1292 (I) Static declarations are not
considered for a function call if the function is not qualified.

Comment 2

[Andrew Paprocki]

Refreshing this bug, as the existing patch is for a much older version. Back then, only this file failed. Now I have a new patch against trunk which fixes this same exact issue now present in the following files:

+++ b/js/src/jsclone.cpp        Wed Dec 22 16:59:11 2010 -0500
+++ b/js/src/jsgc.cpp   Wed Dec 22 16:59:11 2010 -0500
+++ b/js/src/jsgcinlines.h      Wed Dec 22 16:59:11 2010 -0500
+++ b/js/src/jsiter.cpp Wed Dec 22 16:59:11 2010 -0500
+++ b/js/src/jstypedarray.cpp   Wed Dec 22 16:59:11 2010 -0500
+++ b/js/src/v8-dtoa/checks.h   Wed Dec 22 16:59:11 2010 -0500

Comment 3

[Andrew Paprocki]

Attachment: Properly scope external calls in templated functions

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 499380 [details] [diff] [review]
Properly scope external calls in templated functions

r+ before a?, please

Comment 6

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/tracemonkey/rev/a65b4b1d9676

Comment 7

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/a65b4b1d9676