58713 - After delete an account the next account should be selected

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Henrik Gemal]

If you have 5 accounts and delete number 4, number 1 is selected after the delete.
When you delete the next account should be selected.
So deleting number 4 out of 5 should select number 4 of out 4 af the delete.
Deleting number 4 out of 4 should select number 3 of out 3 af the delete.
etc. etc. etc...

Comment 1

[(not reading, please use [e-mail] instead)]

mass re-assign of account manager bugs to racham.

Comment 2

[Matthew T (active 1999-2002)]

*** This bug has been marked as a duplicate of 27417 ***

Comment 3

[Ninoschka Baca]

Verified Duplicate.

Comment 4

[Ninoschka Baca]

Reopening because I believe this bug depends on bug# 27417. I also I don't want
to miss testing this case when 27417 is fixed.

Comment 5

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 6

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 7

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 8

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 9

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 10

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 11

[Robert Kaiser]

This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 12

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420

Comment 13

[Karsten Düsterloh]

Still valid when deleting accounts which are not the first one in the tree.

Comment 14

[:aceman]

I'll try to look.

Comment 15

[:aceman]

Confirming, it always selects the top one. I'll try to fix this.

Usul, could you please hide the duplicate comment 7 to comment 11 to clean up this bug?

Comment 16

[:aceman]

OK, I have a working patch ready but need to wait until bug 740617 lands as it touches the same function.

Comment 17

[:aceman]

Attachment: patch

But let's collect some reviews in the mean time.

Comment 18

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 614193 [details] [diff] [review]
patch

I'm pretty happy with this behaviour.  ui-r=me.

Oh, and I'ld like to see some tests, of course.  ;)

Thanks,
Blake.

Comment 19

[:aceman]

I'd like to see some too! :)

Comment 20

[Ian Neal]

Comment on attachment 614193 [details] [diff] [review]
patch

I presume moving to Services.jsm/mailServices.js is in another bug?

>     dump("failure to remove account: " + ex + "\n");
Would we want to use reportError rather than dump here?

r=me with those answered/addressed.

Comment 21

[:aceman]

Yes, that onRemoveAccount function is already moved to Services in bug 740617 (the patch is already bitrotted :)) Moving the rest of the file is bug 738810.

Comment 22

[:aceman]

Attachment: patch v2

Thanks, fixed, plus a bit of planned bitrot.

Comment 23

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 618025 [details] [diff] [review]
patch v2

Review of attachment 618025 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/AccountManager.js
@@ +509,5 @@
> +  let serverIndex = serverList.indexOf(server);
> +
> +  // After the current server is deleted, choose the next server/account,
> +  // or the previous one if the last one was deleted.
> +  if (serverIndex == serverList.length - 1)

Suppose we only have one server, and we've removed it.

So serverIndex = 0, serverList.length = 1.

serverIndex == serverList.length - 1

We then run serverIndex--, so serverIndex is now -1.  And then we try to access serverList[-1], which doesn't make much sense.

We should definitely handle that case.

@@ +529,3 @@
>    }
>    catch (ex) {
> +    Components.utils.reportError("failure to remove account: " + ex + "\n");

The \n isn't needed.

@@ +532,2 @@
>      let alertText = bundle.getString("failedRemoveAccount");
>      Services.prompt.alert(window, null, alertText);;

While you're here - can you remove the double semi-colon?

Comment 24

[:aceman]

(In reply to Mike Conley (:mconley) from comment #23)
> ::: mailnews/base/prefs/content/AccountManager.js
> We then run serverIndex--, so serverIndex is now -1.  And then we try to
> access serverList[-1], which doesn't make much sense.
> 
> We should definitely handle that case.
OK, I can support that ofr safety. But I think it is currently unrealistic as the Local Folders can't be removed. But maybe it is possible to not have them.

Comment 25

[:aceman]

Attachment: patch v3

Comment 26

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 619286 [details] [diff] [review]
patch v3

Review of attachment 619286 [details] [diff] [review]:
-----------------------------------------------------------------

Just one last thing.  Beyond that, r=me.

Great job, as usual!

::: mailnews/base/prefs/content/AccountManager.js
@@ +524,5 @@
>      if (serverId in accountArray) {
>        delete accountArray[serverId];
>      }
> +
> +    if (serverIndex >= 0)

Maybe I'm being paranoid, but I'd also like a final check to ensure that serverIndex < serverList.length.

Comment 27

[:aceman]

Attachment: patch v4

Thanks.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/ddd7afa181b2

Comment 29

[Ryan VanderMeulen [:RyanVM]]

Tests checked in.
https://hg.mozilla.org/comm-central/rev/0cf5688a02e9