Closed
Bug 587177
Opened 14 years ago
Closed 9 years ago
Update all comments before SetOriginalURI during redirects in nsHttpChannel and other places
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
3.19 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
The comment is currently 'Make sure to do this _after_ making all the OnChannelRedirect calls' and should change to 'Make sure to do this after we received redirect veto answer, i.e. after all sinks had been notified' or something like this.
|
||
Comment 1•9 years ago
|
||
low hanging fruit.. do it or resolve bug plz.
Flags: needinfo?(honzab.moz)
Whiteboard: [necko-backlog]
|
Assignee | |
Comment 2•9 years ago
|
||
Hope my English is ok.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Flags: needinfo?(honzab.moz)
Attachment #8720387 -
Flags: review?(mcmanus)
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8720387 [details] [diff] [review]
v1
Review of attachment 8720387 [details] [diff] [review]:
-----------------------------------------------------------------
thanks!
Attachment #8720387 -
Flags: review?(mcmanus) → review+
|
|
||
Updated•9 years ago
|
Whiteboard: [necko-backlog] → [necko-active]
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•