Closed Bug 587215 Opened 11 years ago Closed 11 years ago

Sync UI: Error notifications aren't displayed

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta5+

People

(Reporter: philikon, Assigned: philikon)

References

Details

(Whiteboard: [sync-ui-followup])

Attachments

(1 file)

Probably during the no-statusbar-button-hmm-maybe-wait-no-maybe-yes malarkey, the Firefox port of the UI ended up without notifications.xml and hence without error reporting.
Attached patch v1Splinter Review
Port of the error notifications.

NB: I'm away for a week starting tomorrow, so someone else will have to land or address review comments if people feel this needs to land urgently.
Assignee: nobody → philipp
Attachment #465903 - Flags: review?(dolske)
Didn't mean to let this slip through the cracks!

(In reply to comment #1)
> NB: I'm away for a week starting tomorrow, so someone else will have to land or
> address review comments if people feel this needs to land urgently.

I can do that if need be.
Requesting blocking2.0
blocking2.0: --- → ?
blocking2.0: ? → beta5+
Comment on attachment 465903 [details] [diff] [review]
v1

I'm feel a bit grumbly about adding another type of notification, but I guess this is fine.
Attachment #465903 - Flags: review?(dolske) → review+
(In reply to comment #4)
> I'm feel a bit grumbly about adding another type of notification, but I guess
> this is fine.

I share your concern. It's likely to change before the final, depending on how bug 589981 pans out.
http://hg.mozilla.org/mozilla-central/rev/fb26f9cb3262
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.