Closed Bug 587277 Opened 9 years ago Closed 9 years ago

TM: ExecutablePool release race

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta4+

People

(Reporter: cdleary, Assigned: cdleary)

Details

Attachments

(1 file)

ASSERTION FAILED: m_refCount != 0
(/builds/slave/tracemonkey-linux64-debug/build/js/src/assembler/jit/ExecutableAllocator.h:115 void JSC::ExecutablePool::release())
NEXT ERROR TEST-UNEXPECTED-FAIL | /tests/dom/src/threads/test/test_suspend.html | Exited with code 11 during test run
Ultimately we want to put the ExecutableAllocator instance per-compartment (note that compartments can migrate across threads, so putting it in ThreadData isn't appropriate). As a stopgap solution to avoid races, we'll do atomic refcounts on the ExecutablePools.
Comment on attachment 465954 [details] [diff] [review]
Atomic refcount of ExecutablePools.

File a follow-up to deal with this issue. I will check this into TM now.
Attachment #465954 - Flags: review?(sayrer) → review+
(In reply to comment #3)
> File a follow-up to deal with this issue.

Bug 587288 filed.
blocking2.0: --- → beta4+
http://hg.mozilla.org/mozilla-central/rev/9825a728b2cb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.