Closed
Bug 587345
Opened 14 years ago
Closed 14 years ago
deAgnostify nsXULPDGlobalObject some
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
|
10.41 KB,
patch
|
Details | Diff | Splinter Review |
Like bug #575431.
Attachment #466010 -
Flags: review?(jst)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 466010 [details] [diff] [review]
Patch v1
While changing nsnull being returned as an nsresult to NS_OK is a good chang :) I don't think we should be changing nsnull to NULL when actually dealing with pointers in C++ code.
r=jst either way.
Attachment #466010 -
Flags: review?(jst) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 466010 [details] [diff] [review]
Patch v1
I understood we were moving toward more standard C++, including NULLs, but that might just be bsmedberg.
Attachment #466010 -
Flags: approval2.0?
|
||
Comment 3•14 years ago
|
||
What's the win here that would induce us to take this now, instead of after branching?
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 466010 [details] [diff] [review]
Patch v1
I think we should wait until we've branched with this.
Attachment #466010 -
Flags: approval2.0? → approval2.0-
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 6•14 years ago
|
||
I tried to land this on cedar, but it doesn't apply cleanly. Please submit a new version of the patch (or land it on cedar yourself).
|
|
Assignee | |
Comment 7•14 years ago
|
||
This one should apply. Thanks!
Attachment #466010 -
Attachment is obsolete: true
|
|
||
Comment 8•14 years ago
|
||
Whiteboard: [needs landing] → [needs landing][fixed-in-cider]
|
|
||
Updated•14 years ago
|
Whiteboard: [needs landing][fixed-in-cider] → [needs landing][fixed-in-cedar]
|
|
||
Comment 9•14 years ago
|
||
Backed out because it broke the build:
http://hg.mozilla.org/projects/cedar/rev/4f0c8bd1a8fa
Whiteboard: [needs landing][fixed-in-cedar] → [needs landing][not-ready]
|
|
Assignee | |
Comment 10•14 years ago
|
||
That's why we should not have assertions.
Attachment #520961 -
Attachment is obsolete: true
|
|
||
Comment 11•14 years ago
|
||
Pushed to try: http://tbpl.mozilla.org/?tree=MozillaTry&rev=8e11ded21a03
|
|
||
Comment 12•14 years ago
|
||
|
|
Assignee | |
Comment 13•14 years ago
|
||
Third time's the charm, right?
Attachment #520985 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 14•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing][not-ready]
|
|
Assignee | |
Updated•14 years ago
|
Target Milestone: --- → mozilla2.2
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•