deAgnostify nsXULPDGlobalObject some

RESOLVED FIXED in mozilla5

Status

()

Core
DOM
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla5
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 466010 [details] [diff] [review]
Patch v1

Like bug #575431.
Attachment #466010 - Flags: review?(jst)
Comment on attachment 466010 [details] [diff] [review]
Patch v1

While changing nsnull being returned as an nsresult to NS_OK is a good chang :) I don't think we should be changing nsnull to NULL when actually dealing with pointers in C++ code.

r=jst either way.
Attachment #466010 - Flags: review?(jst) → review+
(Assignee)

Comment 2

7 years ago
Comment on attachment 466010 [details] [diff] [review]
Patch v1

I understood we were moving toward more standard C++, including NULLs, but that might just be bsmedberg.
Attachment #466010 - Flags: approval2.0?
What's the win here that would induce us to take this now, instead of after branching?
Comment on attachment 466010 [details] [diff] [review]
Patch v1

I think we should wait until we've branched with this.
Attachment #466010 - Flags: approval2.0? → approval2.0-
(Assignee)

Comment 5

7 years ago
Sure.
Whiteboard: [needs landing]
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

7 years ago
Depends on: 610267
(Assignee)

Updated

7 years ago
Blocks: 620000
I tried to land this on cedar, but it doesn't apply cleanly.  Please submit a new version of the patch (or land it on cedar yourself).
(Assignee)

Comment 7

6 years ago
Created attachment 520961 [details] [diff] [review]
Patch for checkin

This one should apply. Thanks!
Attachment #466010 - Attachment is obsolete: true
http://hg.mozilla.org/projects/cedar/rev/05369f93c49a
Whiteboard: [needs landing] → [needs landing][fixed-in-cider]
Whiteboard: [needs landing][fixed-in-cider] → [needs landing][fixed-in-cedar]
Backed out because it broke the build:

http://hg.mozilla.org/projects/cedar/rev/4f0c8bd1a8fa
Whiteboard: [needs landing][fixed-in-cedar] → [needs landing][not-ready]
(Assignee)

Comment 10

6 years ago
Created attachment 520985 [details] [diff] [review]
Patch for checkin

That's why we should not have assertions.
Attachment #520961 - Attachment is obsolete: true
Pushed to try: http://tbpl.mozilla.org/?tree=MozillaTry&rev=8e11ded21a03
New try job: http://tbpl.mozilla.org/?tree=MozillaTry&rev=c355ae2f3d6f
(Assignee)

Comment 13

6 years ago
Created attachment 521127 [details] [diff] [review]
Patch for checkin

Third time's the charm, right?
Attachment #520985 - Attachment is obsolete: true
(Assignee)

Comment 14

6 years ago
http://hg.mozilla.org/mozilla-central/rev/83b87584d902
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing][not-ready]
(Assignee)

Updated

6 years ago
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.