Closed Bug 587372 Opened 14 years ago Closed 13 years ago

Localized cl.exe uses a localized string for /showIncludes

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking2.0 final+)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- final+

People

(Reporter: emk, Assigned: emk)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Using an environment variable v2
6.38 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Japanese MSVC compiler prefixes "メモ: インクルード ファイル:" instead of "Note: including file:". cl.py do not handle this correctly.
Oh man, this is going to be fun.
Workaround: chcp.com 437
Attached patch Make prefix string configurable (obsolete) — — Splinter Review 
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED

        Attachment #466114 -
        Flags: review?(ted.mielczarek)

    
    

    
  
Comment on attachment 466114 [details] [diff] [review]
Make prefix string configurable

I'd rather not turn cl.py into a preprocessed file. How about you just AC_SUBST that value, then cl.py can read it as an environment variable (with the default being what it currently is)?

Also, I hate that Microsoft localizes their compiler output.

        Attachment #466114 -
        Flags: review?(ted.mielczarek) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Using an environment variable (obsolete)
        — 
          — Splinter Review
      

    


  
> Also, I hate that Microsoft localizes their compiler output.
We can do nothing about that :(

        Attachment #466114 -
        Attachment is obsolete: true

        Attachment #472112 -
        Flags: review?(ted.mielczarek)

    
    

    
  


  
The magic number 21 also needs to be changed.

        Attachment #472112 -
        Attachment is obsolete: true

        Attachment #472141 -
        Flags: review?(ted.mielczarek)

        Attachment #472112 -
        Flags: review?(ted.mielczarek)

    
    

    
  
Comment on attachment 472141 [details] [diff] [review]
Using an environment variable v2

It might be nice if we could figure out from the version check we already do in configure if this test is necessary. (Can we figure out if we're using an en-US compiler from just the "cl.exe -help" text?)

But this is fine, anyway.

        Attachment #472141 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
This is very important for non-English developers to build the tree correctly.

(In reply to comment #7)
> It might be nice if we could figure out from the version check we already do in
> configure if this test is necessary. (Can we figure out if we're using an en-US
> compiler from just the "cl.exe -help" text?)
I'd file a followup bug.
blocking2.0: --- → ?

    
  
blocking2.0: ? → final+

    
  
Keywords: checkin-needed

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/fa73c5362474

I'm not sure whether I should mark this bug fixed now, so I'm leaving it.
Keywords: checkin-needed

    
    

    
  
I observed that dependencies are correctly resolved on Japanese locale.
Console does no loner spit out garbages. Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
  
Depends on: 600788

    
    

    
  
(In reply to comment #8)
> > It might be nice if we could figure out from the version check we already do in
> > configure if this test is necessary. (Can we figure out if we're using an en-US
> > compiler from just the "cl.exe -help" text?)
> I'd file a followup bug.
Filed bug 600788.

    
  
Blocks: 807066

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.