Closed Bug 587398 Opened 10 years ago Closed 10 years ago
Alt+Home Keyboard Shortcut Broken; Key Event Modifier navigator
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:2.0b4pre) Gecko/20100814 SeaMonkey/2.1a3pre Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b4pre) Gecko/20100814 SeaMonkey/2.1a3pre Alt+Home keyboard shortcut should load Home Page. It no longer does. Reproducible: Always Steps to Reproduce: 1. Open browser 2. Hit Alt+Home Actual Results: None. Expected Results: Home Page should load. 2010-08-08 works 2010-08-09 broken (hope I've got this right): http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2010-08-09&enddate=2010-08-10 Possibly: Warning: Key event not available on some keyboard layouts: key="d" modifiers="accel,alt" Source File: chrome://navigator/content/navigator.xul Line: 0 Which then points to these two bugs: Bug 427520 - List of warnings for |Bug 311756 – Some "Warning: Key event not available on ...", after 2008-04-07 checkin Bug 311756 - Some "Warning: Key event not available on ..."
you're not alone, therube. tested this bug on my WinXP SP3 computer with SM 2.1a3pre 20100811 nightly build and Alt+Home key combo does not load the Seamonkey home page. I guess this bug happens on all supported versions of Windows with the 8/9/2010 nightly build or higher installed.
I made some alert-debugging and found out that target in http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#850 is null, so we don't enter any of the switch cases. Perhaps related to bug 588070?
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
Version: unspecified → Trunk
It's unanticipated fallout from the Places bookmarks landing - the old BrowserHome method ignored the Alt key, but the new one does not. The quick fix is to make key_home use oncommand="BrowserHome();" instead.
This patch implements the quick fix Neil mentioned in the previous comment.
Assignee: nobody → aqualon
Status: NEW → ASSIGNED
Attachment #469037 - Flags: review?(iann_bugzilla)
This is an alternative approach, where we set target to current if it's null and alt-key is pressed. Cannot say if this is a good idea, because I didn't understand from the usage of BrowserHome() why we need the aEvent at all.
Attachment #469038 - Flags: feedback?(iann_bugzilla)
Comment on attachment 469037 [details] [diff] [review] change caller (Neil's proposal) [Checkin: Comment 8] As there will be only one consumer for Browser:Home left, is it worth removing it completely?
Attachment #469037 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 469038 [details] [diff] [review] change callee (alternativ approach) I prefer the other approach.
Attachment #469038 - Flags: feedback?(iann_bugzilla) → feedback-
Comment on attachment 469037 [details] [diff] [review] change caller (Neil's proposal) [Checkin: Comment 8] http://hg.mozilla.org/comm-central/rev/ba68b04c0ab1
Attachment #469037 - Attachment description: change caller (Neil's proposal) → change caller (Neil's proposal) [Checkin: Comment 8]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
(In reply to comment #5) >I didn't understand from the usage of BrowserHome() why we need the aEvent at all. Holding Ctrl down while clicking the Home button, or middle-clicking the Home button, will cause the home page to open in a new tab or window, assuming you have tabbed browsing preferences configured appropriately.
Attachment #469038 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.