587469 - Remove image map quirk from bug 264624

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

No other browser has this particular quirk, and the testcases in bug 264624 all pass without it. (I think thanks to the HTML5 parser.)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 466139 [details] [diff] [review]
Patch v1

Since Mats fixed Bug 264624, he could review this.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 466139 [details] [diff] [review]
Patch v1

Sure.

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 466139 [details] [diff] [review]
Patch v1

The code change looks good, but the test doesn't do what it's
supposed to do.  First, you need to include the script
"/tests/SimpleTest/EventUtils.js" for synthesizeMouse,
then the test also passes without the code change because
50,50 is actually outside the image (which is the builtin
"broken URL" image).  Clicking at 2,2 should work.
r=mats with that

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

EventUtils.js was already included, and I fixed the src and the coords to ensure I hit the right thing.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/31464345fc6e

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(FWIW, I claim the dromaeo improvement on that push <http://groups.google.com/group/mozilla.dev.tree-management/browse_thread/thread/47eec39b9eb490cf/8c652ab00d54a991>.)

Comment 9

[Eric Shepherd [:sheppy]]

Am I correctly interpreting this code as we no longer skip over empty maps in favor of non-empty ones if we find a matching empty map before a non-empty one, when in quirks mode?

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

You are.

Comment 11

[Eric Shepherd [:sheppy]]

OK, I need to clarify further. Are we talking about empty vs. non-empty map areas or maps?

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

maps, as in the test:

<map name=a></map>
<map name=a><area shape=rect coords=25,25,75,75 href=#fail></map>
<img usemap=#a src=image.png>

Comment 13

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/HTML/Element/map

Also mentioned on Firefox 5 for developers.