Closed Bug 587469 Opened 12 years ago Closed 11 years ago

Remove image map quirk from bug 264624


(Core :: DOM: Core & HTML, defect)

Not set





(Reporter: Ms2ger, Assigned: Ms2ger)



(Keywords: dev-doc-complete, html5)


(1 file, 2 obsolete files)

No other browser has this particular quirk, and the testcases in bug 264624 all pass without it. (I think thanks to the HTML5 parser.)
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #466139 - Flags: review?(Olli.Pettay)
Comment on attachment 466139 [details] [diff] [review]
Patch v1

Since Mats fixed Bug 264624, he could review this.
Attachment #466139 - Flags: review?(Olli.Pettay)
Comment on attachment 466139 [details] [diff] [review]
Patch v1

Attachment #466139 - Flags: review?(matspal)
Comment on attachment 466139 [details] [diff] [review]
Patch v1

The code change looks good, but the test doesn't do what it's
supposed to do.  First, you need to include the script
"/tests/SimpleTest/EventUtils.js" for synthesizeMouse,
then the test also passes without the code change because
50,50 is actually outside the image (which is the builtin
"broken URL" image).  Clicking at 2,2 should work.
r=mats with that
Attachment #466139 - Flags: review?(matspal) → review+
Attached patch Patch v2 (obsolete) — Splinter Review
EventUtils.js was already included, and I fixed the src and the coords to ensure I hit the right thing.
Attachment #466139 - Attachment is obsolete: true
Whiteboard: [needs landing]
Depends on: post2.0
Attachment #483413 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [needs landing]
Closed: 11 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Am I correctly interpreting this code as we no longer skip over empty maps in favor of non-empty ones if we find a matching empty map before a non-empty one, when in quirks mode?
You are.
OK, I need to clarify further. Are we talking about empty vs. non-empty map areas or maps?
maps, as in the test:

<map name=a></map>
<map name=a><area shape=rect coords=25,25,75,75 href=#fail></map>
<img usemap=#a src=image.png>
Documentation updated:

Also mentioned on Firefox 5 for developers.
You need to log in before you can comment on or make changes to this bug.