The default bug view has changed. See this FAQ.

Remove image map quirk from bug 264624

RESOLVED FIXED in mozilla5

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({dev-doc-complete, html5})

Trunk
mozilla5
dev-doc-complete, html5
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
No other browser has this particular quirk, and the testcases in bug 264624 all pass without it. (I think thanks to the HTML5 parser.)
(Assignee)

Comment 1

7 years ago
Created attachment 466139 [details] [diff] [review]
Patch v1
Attachment #466139 - Flags: review?(Olli.Pettay)
Comment on attachment 466139 [details] [diff] [review]
Patch v1

Since Mats fixed Bug 264624, he could review this.
Attachment #466139 - Flags: review?(Olli.Pettay)
(Assignee)

Comment 3

7 years ago
Comment on attachment 466139 [details] [diff] [review]
Patch v1

Sure.
Attachment #466139 - Flags: review?(matspal)
Comment on attachment 466139 [details] [diff] [review]
Patch v1

The code change looks good, but the test doesn't do what it's
supposed to do.  First, you need to include the script
"/tests/SimpleTest/EventUtils.js" for synthesizeMouse,
then the test also passes without the code change because
50,50 is actually outside the image (which is the builtin
"broken URL" image).  Clicking at 2,2 should work.
r=mats with that
Attachment #466139 - Flags: review?(matspal) → review+
(Assignee)

Comment 5

7 years ago
Created attachment 483413 [details] [diff] [review]
Patch v2

EventUtils.js was already included, and I fixed the src and the coords to ensure I hit the right thing.
Attachment #466139 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Whiteboard: [needs landing]
(Assignee)

Updated

7 years ago
Depends on: 610267
(Assignee)

Comment 6

6 years ago
Created attachment 521566 [details] [diff] [review]
Patch for checkin
Attachment #483413 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/31464345fc6e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
(Assignee)

Comment 8

6 years ago
(FWIW, I claim the dromaeo improvement on that push <http://groups.google.com/group/mozilla.dev.tree-management/browse_thread/thread/47eec39b9eb490cf/8c652ab00d54a991>.)
Keywords: dev-doc-needed
Am I correctly interpreting this code as we no longer skip over empty maps in favor of non-empty ones if we find a matching empty map before a non-empty one, when in quirks mode?
(Assignee)

Comment 10

6 years ago
You are.
OK, I need to clarify further. Are we talking about empty vs. non-empty map areas or maps?
(Assignee)

Comment 12

6 years ago
maps, as in the test:

<map name=a></map>
<map name=a><area shape=rect coords=25,25,75,75 href=#fail></map>
<img usemap=#a src=image.png>
Documentation updated:

https://developer.mozilla.org/en/HTML/Element/map

Also mentioned on Firefox 5 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.