Closed Bug 587483 Opened 9 years ago Closed 9 years ago

warning: comparison between signed and unsigned integer expressions in FrameLayerBuilder

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file)

layout/base/FrameLayerBuilder.cpp:
 In member function ‘void mozilla::<unnamed>::ContainerState::ProcessDisplayItems(const nsDisplayList&, const nsRect*)’:
923: warning: comparison between signed and unsigned integer expressions
 In static member function ‘static void mozilla::FrameLayerBuilder::DrawThebesLayer(mozilla::layers::ThebesLayer*, gfxContext*, const nsIntRegion&, const nsIntRegion&, void*)’:
1371: warning: comparison between signed and unsigned integer expressions
Attached patch patchSplinter Review
i don't know why AppUnitsPerDevPixel are signed in our codebase and i don't really care. this is the simplest path to a warning free file.
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #466151 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/187e3c434e7e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.