587534 - make sure plugins get hidden when they are unregistered for geometry updates

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: patch

My understanding is that there is no guarantee that a plugin geometry update will happen before we unregister the plugin for geometry updates. Some other patches I will probably need for 130078 cause this to happen frequently where we freeze a presshell later into the loading of the next page then we used to and there hasn't been enough time for a plugin geometry update to have run and hid the plugin.

Is there a better way to ensure the plugin gets hidden before StopPluginInternal is called?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 466193 [details] [diff] [review]
patch

+      if (!configurations.IsEmpty()) {
+        parent->ConfigureChildren(configurations);
+        DidSetWidgetGeometry();

Good catch.

I don't think you need the "if" test here, you can do this unconditionally.

Comment 2

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/b9682fe6cfcd