Fix broken UnicharSelfTest.cpp

RESOLVED FIXED

Status

()

Core
Internationalization
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
intl/unicharutil/tests/UnicharSelfTest.cpp was broken by the de-COMification of nsICaseConverter in bug 575043.

This test is not run as part of the automatic test suite, but it would be nice to get it working again for purposes of testing code in bug 145975 for correctness and speed.
(Assignee)

Comment 1

8 years ago
I tried to do this on Friday, but couldn't get my modifications to build.  I'll post what I have on Monday; it would be nice if someone who understands the build better (:cough: khuey) could look at it.
So the right way to do this is probably to put back the contract ID stuff that I accidentally removed.  I see you marked this blocking the perf bug though; you probably don't want to test this stuff through XPCOM if you're interested in meaningful perf numbers.

We'll chat tomorrow.
(Assignee)

Comment 3

8 years ago
Well, if some stuff was accidentally removed, we should add it back.  But I was figuring that we'd just de-COM the test.
(Assignee)

Comment 4

8 years ago
Created attachment 466435 [details] [diff] [review]
Patch v1

Huh.  I managed to get it to work.  I thought this was what I was doing all along...
Assignee: smontagu → justin.lebar+bug
Status: NEW → ASSIGNED
Attachment #466435 - Flags: review?(me)
Comment on attachment 466435 [details] [diff] [review]
Patch v1

r=me (this is essentially a linkage/build issue so I don't think that Simon needs to review it.

Can you file a followup on making this use the test harness so that failures cause the build to go orange?
Attachment #466435 - Flags: review?(me) → review+
(Assignee)

Updated

8 years ago
Attachment #466435 - Flags: approval2.0?
(Assignee)

Updated

8 years ago
Blocks: 587831
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> Can you file a followup on making this use the test harness so that failures
> cause the build to go orange?

Filed as bug 587831.
(Assignee)

Comment 7

8 years ago
Comment on attachment 466435 [details] [diff] [review]
Patch v1

Unflagging for approval since this is test-only.
Attachment #466435 - Flags: approval2.0?
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/878049d882e6
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.