Open
Bug 587632
Opened 14 years ago
Updated 2 years ago
nsXULPopupManager::ShowPopupCallback leaks item when ENSURE_TRUE(weakFrame.IsAlive()) fails
Categories
(Core :: XUL, defect)
Tracking
()
NEW
People
(Reporter: timeless, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file)
|
1.11 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
560 nsXULPopupManager::ShowPopupCallback(nsIContent* aPopup,
564 {
572 nsMenuChainItem* item =
573 new nsMenuChainItem(aPopupFrame, aIsContextMenu, popupType);
574 if (!item)
575 return;
595 nsWeakFrame weakFrame(aPopupFrame);
596 PRBool hasChildren = aPopupFrame->ShowPopup(aIsContextMenu, aSelectFirstItem);
597 ENSURE_TRUE(weakFrame.IsAlive());
smaug is forcing me to get rid of oom checks for new
|
||
Comment 2•14 years ago
|
||
Comment on attachment 466579 [details] [diff] [review] autoptr > mPopups = item; > SetCaptureState(oldmenu); > } >+ item.forget(); Ideally you would mNoHidePanels = item.forget(); etc.
Attachment #466579 -
Flags: review?(neil) → review+
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
|
||
Comment 3•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: timeless → nobody
Status: ASSIGNED → NEW
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•