Closed
Bug 587635
Opened 15 years ago
Closed 2 years ago
PKIX_NULLCHECK_ONE in pkix_pl_CertNameConstraints_CheckNameSpaceNssNames bypasses cleanup and leaks arena
Categories
(NSS :: Libraries, defect, P5)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: timeless, Unassigned)
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file)
|
1.84 KB,
patch
|
alvolkov.bgs
:
review+
|
Details | Diff | Splinter Review |
305 pkix_pl_CertNameConstraints_CheckNameSpaceNssNames(
326 arena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE);
347 do {
351 for (i = 0; i < numItems; i++) {
353 PKIX_NULLCHECK_ONE(nssNameConstraintsList);
354 nssNameConstraints = *(nssNameConstraintsList + i);
355 PKIX_NULLCHECK_ONE(nssNameConstraints);
382 cleanup:
384 if (arena){
387 PORT_FreeArena(arena, PR_FALSE);
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #466584 -
Flags: review?(alexei.volkov.bugs)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 466584 [details] [diff] [review]
patch
It seems like there is a redundancy in the code since cleanup label is not needed. Only macros like PKIX_CHECK do goto to cleanup.
r=alexei
Attachment #466584 -
Flags: review?(alexei.volkov.bugs) → review+
|
||
Comment 3•15 years ago
|
||
Alexei,
Don't forget. Now that you've given this patch r+, you need to commit it.
|
||
Comment 4•3 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: timeless → nobody
Status: ASSIGNED → NEW
|
||
Updated•3 years ago
|
Severity: normal → S3
|
||
Updated•2 years ago
|
Severity: S3 → S4
Status: NEW → RESOLVED
Closed: 2 years ago
Priority: -- → P5
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•