587719 - Attempt to use application/x-moz-keywordsearch submission type for keyword search, before falling back to default submission type

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

This will allow search engines to specify a keyword-specific <Url>, if using the default <Url type="text/html"> isn't suitable (e.g. if you want different parameters).

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

That patch also makes keyword.url non-localizable, since there's no longer a reason for it to be.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 466363 [details] [diff] [review]
patch

Looks good to me, not that I have a good idea on the nsDefaultURIFixup.cpp part, I guess jst is up for review on that?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

yep

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: updated patch

Discussed this with Jeff, added a comment with followup accordingly.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 466414 [details] [diff] [review]
updated patch

Looks fine, but add a comment describing why you're:

pref("keyword.URL", "");

and maybe mention the future bug near:
+const URLTYPE_MOZ_KEYWORDSEARCH = "application/x-moz-keywordsearch";

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Attachment: comments addressed

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Patch summary:
- makes change from bug 586821 apply to all locales
 - additional followup special-case bug 587730 for "ru" specifically is ready to land, coordinated with axel and ru localizer
- removes a string (minimal l10n impact)
- no code-level regression risk

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

blocking b4

Comment 10

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/50334c9ac182