Menu structure should look more like other apps'

RESOLVED FIXED

Status

Other Applications
DOM Inspector
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: crussell, Assigned: crussell)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

*Remove the separator before Close in the File menu, and move the Close item to be below the Inspect a URL item.
*Remove the separator before Insert in the Edit menu, and move the Delete item to be below the Paste item.
*Consolidate Edit and Search menus (bug 201834) by placing a separator below the Insert item and moving the three find-related items to be below the separator, removing the Search menu entirely.
*Rename Find Next to Find Again
*Add accel+G for Find Again, and use it as the one displayed in the menu
*For non-SeaMonkey on unix (including OS X), add accel+Shift+Z for Redo, and use it as the one displayed in the menu.

Comment 1

8 years ago
fwiw, SeaMonkey on OSX (in the Edit menu) uses accel+Shift+Z for Redo.
Created attachment 466523 [details] [diff] [review]
cleanup
Assignee: nobody → Sevenspade
Status: NEW → ASSIGNED
Attachment #466523 - Flags: review?(neil)
Created attachment 466525 [details] [diff] [review]
do as stated in comment 0, but use accel+Shift+Z for primary shortcut on all non-Win

SeaMonkey on Linux uses Ctrl+Y for the primary shortcut, despite Firefox's, gedit's, and gcalctool's use of Ctrl+Shift+Z. Like bug 218864, I'm operating under the assumption that this is due to oversight rather than intentional.
Attachment #466525 - Flags: review?(neil)
Attachment #466525 - Flags: feedback?(stefanh)
Created attachment 466526 [details]
GTK file menu on Linux
Created attachment 466527 [details]
GTK edit menu on Linux
Comment on attachment 466526 [details]
GTK file menu on Linux

Note that the "before" view of the File popup on both SeaMonkey and Firefox is also from before bug 218864 was fixed, so the ellipsis on the "Inspect a URL" item should be ignored.

Comment 7

8 years ago
Comment on attachment 466523 [details] [diff] [review]
cleanup

> </overlay>
> 
>-        
>+
Nit: might as well delete the line completely.
Attachment #466523 - Flags: review?(neil) → review+

Comment 8

8 years ago
Comment on attachment 466525 [details] [diff] [review]
do as stated in comment 0, but use accel+Shift+Z for primary shortcut on all non-Win

Looks good to me from a seamonkey mac-perspective. Naturally, that's all I can comment on.
Attachment #466525 - Flags: feedback?(stefanh) → feedback+

Comment 9

8 years ago
Comment on attachment 466525 [details] [diff] [review]
do as stated in comment 0, but use accel+Shift+Z for primary shortcut on all non-Win

[This is going to kill my muscle memory, I'm too used to pressing Alt+S, S!]

>+    <menuitem label="&cmdClose.label;" accesskey="&cmdClose.accesskey;"
>+              observes="cmdClose" key="key_closeInspector"/>
>     <menuseparator/>
>     <menuitem label="&cmdSave.label;" accesskey="&cmdSave.accesskey;"
>               observes="cmdSave" key="key_saveInspector" id="mi-save"/>
>-    <menuseparator/>
>-    <menuitem label="&cmdClose.label;" accesskey="&cmdClose.accesskey;"
>-              observes="cmdClose" key="key_closeInspector"/>
[This confused me until I realised that Exit is added separately.]

>-    <menuseparator position="3"/>
[I find it odd that there's no separator after find next.]

>+    <menuitem id="item:selectByClick"
>               label="&cmdSelectByClick.label;"
>               accesskey="&cmdSelectByClick.accesskey;"
>               observes="cmd:selectByClick"/>
While you're here, would you mind adding type="checkbox"?
Attachment #466525 - Flags: review?(neil) → review+
Pushed with changes from comment 7 and comment 9:
http://hg.mozilla.org/dom-inspector/rev/c35e453c2b82
http://hg.mozilla.org/dom-inspector/rev/56561cc69fb2
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Blocks: 201834
No longer depends on: 201834
You need to log in before you can comment on or make changes to this bug.