Closed Bug 587735 Opened 9 years ago Closed 9 years ago

redefine nRegisterAllocFromSet in terms of lsReg or msReg

Categories

(Core Graveyard :: Nanojit, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: edwsmith, Unassigned)

References

Details

(Whiteboard: fixed-in-nanojit,fixed-in-tracemonkey,fixed-in-tamarin)

Attachments

(1 file)

Once bug 584935 lands, the platform-specific implementations of nRegisterAllocFromSet could be rewritten in terms of lsReg or msReg, to ease maintenance.  We might also get a slight speed bump from them having been inlined.
Depends on: 584275
Depends on: 584935
No longer depends on: 584275
The speedup is 2.4% for the Tamarin's "performance" testsuite on SH4. Thanks for this suggestion!
Attachment #473989 - Flags: review?(edwsmith)
Comment on attachment 473989 [details] [diff] [review]
SH4 backend: redefine Assembler::nRegisterAllocFromSet() in terms of lsReg

Cool.  Just curious, how does GCC implement __builtin_ctz() on SH4?  I didn't think the CPU had a bit-index primitive.
Attachment #473989 - Flags: review?(edwsmith) → review+
Blocks: 602390
Please, could you apply this change? Thanks in advance.
http://hg.mozilla.org/tracemonkey/rev/f36e539c450b
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/f36e539c450b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit,fixed-in-tracemonkey,fixed-in-tamarin
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.