Closed
Bug 587735
Opened 14 years ago
Closed 14 years ago
redefine nRegisterAllocFromSet in terms of lsReg or msReg
Categories
(Core Graveyard :: Nanojit, defect)
Core Graveyard
Nanojit
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edwsmith, Unassigned)
References
Details
(Whiteboard: fixed-in-nanojit,fixed-in-tracemonkey,fixed-in-tamarin)
Attachments
(1 file)
|
718 bytes,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
Once bug 584935 lands, the platform-specific implementations of nRegisterAllocFromSet could be rewritten in terms of lsReg or msReg, to ease maintenance. We might also get a slight speed bump from them having been inlined.
|
Reporter | |
Updated•14 years ago
|
|
||
Comment 1•14 years ago
|
||
The speedup is 2.4% for the Tamarin's "performance" testsuite on SH4. Thanks for this suggestion!
Attachment #473989 -
Flags: review?(edwsmith)
|
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 473989 [details] [diff] [review]
SH4 backend: redefine Assembler::nRegisterAllocFromSet() in terms of lsReg
Cool. Just curious, how does GCC implement __builtin_ctz() on SH4? I didn't think the CPU had a bit-index primitive.
Attachment #473989 -
Flags: review?(edwsmith) → review+
|
|
||
Comment 3•14 years ago
|
||
Please, could you apply this change? Thanks in advance.
|
||
Comment 4•14 years ago
|
||
Whiteboard: fixed-in-nanojit
|
||
Comment 5•14 years ago
|
||
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
|
||
Comment 6•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit,fixed-in-tracemonkey,fixed-in-tamarin
|
Assignee | |
Updated•11 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•