588099 - Allow users to select PGO/non-PGO windows builds for tryserver

Status: RESOLVED DUPLICATE of bug 691673

(Release Engineering :: General, defect, P5)

Description

[Chris AtLee [:catlee]]

If you don't want any perf results for your try push, then doing a non-PGO build will save quite a bit of time, and you'll get your results back faster!

Comment 1

[(not currently active) Ted Mielczarek]

And considering we don't run Talos by default...

I suspect that most people don't care about PGO, they just want to know if it compiles and passes tests. As long as PGO is still an option, for 100% fidelity to the production tree, then that should be fine.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

We should also make it clear somewhere that if you want Talos you need the PGO build.

Comment 3

[Serge Gautherie (:sgautherie)]

Could it be possible to make --*able-profile-guided-optimization depend on the Try Chooser Talos option by default, then let the user override that as needed?

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to comment #3)
> Could it be possible to make --*able-profile-guided-optimization depend on the
> Try Chooser Talos option by default, then let the user override that as needed?

This sounds like a good idea. If you request Talos runs on your Windows builds, you get a PGO build, otherwise you don't. Then you can provide a different switch that will let you opt into PGO builds without Talos for the rare occasion where that's wanted.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

this is going to be implemented by bug 691673