588136 - Make ispdb cache-friendly

Status: RESOLVED FIXED

(Webtools :: ISPDB Server, defect)

Description

[Philippe M. Chiasson (:gozer)]

Needs to be setting some Cache-Control: hits to enable caching. Especially important for XML dumps that would go to the client.

Comment 1

[Sergio Roberto]

I'm thinking in something like:
 - add a default max-age of 600s.
 - for export_xml/id (exports a config XML): set no-cache to Cache-Control (it will cache but will always check with the server if the cache file is updated, and we can provide the last-update value using config.last_update_datetime)
  - list/xml/ (export list with config IDs and its last_update_datetime) - set no-cache to Cache-Control and use last-update as the most recent config.last_update_datetime

The idea is to provide reliable data for XML requests that goes to clients. 

What do you think?

Also, setting Vary: Cookie is enough to cache private data (or should we also add private to Cache-Control, or something else)?

Comment 2

[Sergio Roberto]

This has been fixed on https://github.com/mozilla/ispdb/pull/13