588185 - Mobile desktop builds for linux should build with IPC

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P4)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Desktop builds disable IPC in mozconfig. We should build Linux and Windows with IPC enable. OSX does not support web content IPC.

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

has this build configuration been tested?  Am I correct in assuming the changes for this are limited to the mozconfigs?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Desktop Linux works great with IPC. Desktop Windows will build and should work.

Yes, this is a mozconfig change only.

since --enable-ipc is on by default, we should be able to just remove the --disable-ipc from the mozconfigs for nightly and release fennec 2.0 builds.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

Attachment: buildbot-configs v1

Allow linux and win32 desktop builds to be built with IPC.  Since enabling IPC is the default, remove it from the e10s mozconfigs

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 466843 [details] [diff] [review]
buildbot-configs v1

r=me if you also update or remove the currently unused fennec desktop mozconfigs in mobile-tryserver/.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 466843 [details] [diff] [review]
buildbot-configs v1

I have second thoughts about Windows. There are currently problems with e10s on desktop Windows, so until those are fixed let's only enable Linux.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to comment #5)
> Comment on attachment 466843 [details] [diff] [review]
> buildbot-configs v1
> 
> I have second thoughts about Windows. There are currently problems with e10s on
> desktop Windows, so until those are fixed let's only enable Linux.

no worries, I will land a copy of this without the changes to windows and will also remove the mobile-tryserver desktop mozconfigs

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 466843 [details] [diff] [review]
buildbot-configs v1

http://hg.mozilla.org/build/buildbot-configs/rev/55218bd97eef

This changeset addresses the concerns about win32 having IPC as well as removing the obsolete mozconfigs

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Can't this be closed:fixed ?

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

i was just about to do that :)