Closed Bug 588185 Opened 12 years ago Closed 11 years ago

Mobile desktop builds for linux should build with IPC

Categories

(Release Engineering :: General, defect, P4)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: jhford)

Details

Attachments

(1 file)

Desktop builds disable IPC in mozconfig. We should build Linux and Windows with IPC enable. OSX does not support web content IPC.
has this build configuration been tested?  Am I correct in assuming the changes for this are limited to the mozconfigs?
Desktop Linux works great with IPC. Desktop Windows will build and should work.

Yes, this is a mozconfig change only.

since --enable-ipc is on by default, we should be able to just remove the --disable-ipc from the mozconfigs for nightly and release fennec 2.0 builds.
Allow linux and win32 desktop builds to be built with IPC.  Since enabling IPC is the default, remove it from the e10s mozconfigs
Assignee: nobody → jhford
Status: NEW → ASSIGNED
Attachment #466843 - Flags: review?(aki)
Attachment #466843 - Flags: feedback?(mark.finkle)
Comment on attachment 466843 [details] [diff] [review]
buildbot-configs v1

r=me if you also update or remove the currently unused fennec desktop mozconfigs in mobile-tryserver/.
Attachment #466843 - Flags: review?(aki) → review+
Summary: Mobile desktop builds for linux and windows should build with IPC → Mobile desktop builds for linux should build with IPC
Comment on attachment 466843 [details] [diff] [review]
buildbot-configs v1

I have second thoughts about Windows. There are currently problems with e10s on desktop Windows, so until those are fixed let's only enable Linux.
Attachment #466843 - Flags: feedback?(mark.finkle) → feedback-
(In reply to comment #5)
> Comment on attachment 466843 [details] [diff] [review]
> buildbot-configs v1
> 
> I have second thoughts about Windows. There are currently problems with e10s on
> desktop Windows, so until those are fixed let's only enable Linux.

no worries, I will land a copy of this without the changes to windows and will also remove the mobile-tryserver desktop mozconfigs
Comment on attachment 466843 [details] [diff] [review]
buildbot-configs v1

http://hg.mozilla.org/build/buildbot-configs/rev/55218bd97eef

This changeset addresses the concerns about win32 having IPC as well as removing the obsolete mozconfigs
Priority: -- → P4
Can't this be closed:fixed ?
i was just about to do that :)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.