Closed Bug 588251 Opened 13 years ago Closed 13 years ago

fun.caller should throw if that value corresponds to a strict mode function (?)

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b5
Tracking Flags:
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: Waldo, Assigned: Waldo)

References

(
URL
)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Patch and test
3.05 KB, patch
sayrer
: review+
Details | Diff | Splinter Review 
By my reading of 15.3.5.4 it looks like per ES5 this should pass:

  function nonstrict() { return nonstrict.caller; }
  function strict() { "use strict"; return nonstrict(); }
  try
  {
    strict();
    throw 17;
  }
  catch (e)
  {
    print(e instanceof TypeError ? "PASS" : "FAIL");
  }

Or am I missing something?

Easy two-ish-liner in fun_getProperty, just want to be sure I'm not misreading something.
QA Contact: general → jwalden+bmo
blocking2.0: --- → beta5+
Assignee: general → jwalden+bmo
QA Contact: jwalden+bmo → general
Attached patch Patch and test — — Splinter Review 

        Attachment #468076 -
        Flags: review?

    
  

        Attachment #468076 -
        Flags: review? → review?(sayrer)

    
  

        Attachment #468076 -
        Flags: review?(sayrer) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/58129dadc84f
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla2.0b5

    
  
blocking2.0: beta5+ → beta6+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/58129dadc84f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.