588306 - only invalidate layers on PAINT_IGNORE_SUPPRESSION when there is suppression to ignore

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 466921 [details] [diff] [review]
patch

> if (aFlags & PAINT_IGNORE_SUPPRESSION && builder.IsBackgroundOnly()) {

parens around the & subexpression

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: patch (with parens)

Simple patch, that may help our tests test the paths that we usually use for drawing.

Comment 4

[Timothy Nikkel (:tnikkel)]

If we start suppressing when entering subdocs that have painting suppressed we'll need to do something different here.

Comment 5

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/mozilla-central/rev/e151e2b04a0c

This landed, but, if it is getting in the way of your work, Timothy, then I'm fine if you'd like to back it out until we sort something else out.

Comment 6

[Timothy Nikkel (:tnikkel)]

Not conflicting with my work right now, but suppressing when entering a suppressed subdoc is something I think we want to do.