588319 - test-securable-module.testSecurableModule failures

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

I'm seeing es5-related test failures when testing securable-module on tip on Linux:

(jsdk)myk@myk:~/Projects/jsdk/packages/jetpack-core$ cfx test -F securable-module
...
error: TEST FAILED: test-securable-module.testSecurableModule (exception)
error: An exception occurred.
Traceback (most recent call last):
  File "<string>", line 1, in 
  File "", line 0, in require
  File "resource://jetpack-core-jetpack-core-lib/securable-module.js", line 210, in require
    throw new Error('Module "' + module + '" not found');
  File "", line 0, in Error
Error: Module "es5" not found
.....error: fail: "/blarg/foo" != null
info: Traceback (most recent call last):
  File "<string>", line 1, in null
  File "resource://jetpack-core-jetpack-core-lib/securable-module.js", line 208, in require
    var path = self.fs.resolveModule(rootDir, module);
  File "resource://jetpack-core-jetpack-core-tests/test-securable-module.js", line 264, in anonymous
    test.assertEqual(base, null);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 231, in assertEqual
    this.fail(message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 149, in fail
    console.trace();
error: fail: "es5" != "foo"
info: Traceback (most recent call last):
  File "<string>", line 1, in null
  File "resource://jetpack-core-jetpack-core-lib/securable-module.js", line 208, in require
    var path = self.fs.resolveModule(rootDir, module);
  File "resource://jetpack-core-jetpack-core-tests/test-securable-module.js", line 265, in anonymous
    test.assertEqual(path, "foo");
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 231, in assertEqual
    this.fail(message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 149, in fail
    console.trace();
error: An exception occurred.
Traceback (most recent call last):
  File "<string>", line 1, in 
TypeError: require("es5").init is not a function

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Fix

I still see 2 test failures but they are unrelated to this one.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 467043 [details] [diff] [review]
Fix

Looks good, works well, r=myk!

Comment 3

[Myk Melez [:myk] [@mykmelez]]

I went ahead and pushed this, since we need it to spin the 0.7 RC.

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/bdb08e077013.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".