Closed Bug 588345 Opened 14 years ago Closed 14 years ago

Fix l10n comments for JS/DOM Object Introspector

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(blocking2.0 -)

RESOLVED FIXED
Firefox 4.0b5
Tracking Status
blocking2.0 --- -

People

(Reporter: julian.viereck, Assigned: julian.viereck)

References

Details

(Whiteboard: [kd4b5])

Attachments

(1 file)

Hint by Axel Hecht on bug 573102 (Implementing a JS/DOM Object Introspector), comment 99:

> Can you land a follow up to make the localization notes follow the markup on 
> https://developer.mozilla.org/en/Localization_notes, i.e.
> 
> # LOCALIZATION NOTE (jsPropertyTitle,jsPropertyInspectTitle):...
> 
> Most l10n tools don't offer a source view, but there are l10n tools that
> actually parse that format, and understand when to offer the comment.

Will do so.
Whiteboard: [kd4b5]
Attached patch Patch v1Splinter Review
Fixes the i10n notes as requested.
Comment on attachment 467104 [details] [diff] [review]
Patch v1

Trivial change, therefore ask directly for review and not feedback at first place.
Attachment #467104 - Flags: review?(gavin.sharp)
Requesting blocking status on this bug as it's i10n related and therefore should land before/with b5.
blocking2.0: --- → ?
Comment on attachment 467104 [details] [diff] [review]
Patch v1

r=me, fwiw.

PS: It's l[ocalizatio]n, "oclizatio" being 10 chars, thus l10n (no i). And now you know ;-)
Attachment #467104 - Flags: review+
Attachment #467104 - Flags: review?(gavin.sharp) → review+
(In reply to comment #4)
> PS: It's l[ocalizatio]n, "oclizatio" being 10 chars, thus l10n (no i). And now
> you know ;-)

Ahh, I was wondering what's the 10 is for. Thanks for let me know and for setting r+ on this bug :)

PS: You're quick!
Keywords: checkin-needed
Attachment #467104 - Flags: approval2.0?
Summary: Fix i10n comments for JS/DOM Object Introspector → Fix l10n comments for JS/DOM Object Introspector
Attachment #467104 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/0e6427f28882
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b5
blocking2.0: ? → -
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: