588406 - post_upload.py sometimes fails with OSError: [Errno 17] File exists in ReleaseToDated

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P5)

Description

[Chris Cooper [:coop] (he/him)]

Axel noticed this happening with some l10n uploads. There's a log link in the URL, but here's a snippet in case that goes stale:

/tools/python/bin/python2.5 ../../build/upload.py --base-path ../../dist "../../dist/firefox-3.6.9pre.oc.mac.dmg" ../../dist/install/firefox-3.6.9pre.oc.langpack.xpi
Uploading /builds/slave/mozilla-1.9.2-macosx-l10n-nightly/build/mozilla-1.9.2/dist/firefox-3.6.9pre.oc.mac.dmg

firefox-3.6.9pre.oc.mac.dmg                     0%    0     0.0KB/s   --:-- ETA
firefox-3.6.9pre.oc.mac.dmg                    18% 4404KB   4.3MB/s   00:04 ETA
firefox-3.6.9pre.oc.mac.dmg                    40% 9912KB   4.4MB/s   00:03 ETA
firefox-3.6.9pre.oc.mac.dmg                    62%   15MB   4.5MB/s   00:01 ETA
firefox-3.6.9pre.oc.mac.dmg                    83%   20MB   4.5MB/s   00:00 ETA
firefox-3.6.9pre.oc.mac.dmg                   100%   24MB   4.7MB/s   00:05    
Uploading /builds/slave/mozilla-1.9.2-macosx-l10n-nightly/build/mozilla-1.9.2/dist/install/firefox-3.6.9pre.oc.langpack.xpi

firefox-3.6.9pre.oc.langpack.xpi                0%    0     0.0KB/s   --:-- ETA
firefox-3.6.9pre.oc.langpack.xpi              100%  106KB 105.7KB/s   00:00    
Running post-upload command: post_upload.py -p firefox  -b mozilla-1.9.2-l10n  --buildid 20100817033635 --release-to-latest --release-to-dated
Traceback (most recent call last):
  File "/usr/local/bin/post_upload.py", line 329, in ?
    func(options, upload_dir, files)
  File "/usr/local/bin/post_upload.py", line 98, in ReleaseToDated
    os.symlink(longDir, shortDir)
OSError: [Errno 17] File exists
Encountered error while uploading
Command ['ssh', '-o', 'IdentityFile=~/.ssh/ffxbld_dsa', '[e-mail]', 'post_upload.py -p firefox  -b mozilla-1.9.2-l10n  --buildid 20100817033635 --release-to-latest --release-to-dated "/tmp/tmp.ouqdt10863/" "/tmp/tmp.ouqdt10863//firefox-3.6.9pre.oc.mac.dmg" "/tmp/tmp.ouqdt10863/install/firefox-3.6.9pre.oc.langpack.xpi"'] returned non-zero exit code: 1
make: *** [l10n-upload-oc] Error 2

Comment 1

[[e-mail] (:bhearsum)]

Looks like a race condition. We should probably be using try/except and catching errno 17 instead of checking for existence first:
http://hg.mozilla.org/build/tools/file/tip/stage/post_upload.py#l97

Seems like a low priority, though.

Comment 3

[Axel Hecht [:Pike]]

Two nightlies failed on this today,

Firefox mozilla-1.9.2 linux l10n nightly on 2010/08/24 04:18:16,
moz2-linux-slave19
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-mr/1282648696.1282648899.16113.gz&fulltext=1

Firefox mozilla-1.9.2 linux l10n nightly on 2010/08/24 04:18:16,
moz2-linux-slave16
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-ko/1282648696.1282648899.16115.gz&fulltext=1

(sorry for the dupe)

Comment 4

[Chris Cooper [:coop] (he/him)]

Mass re-assign of post_upload.py bugs to Tomcat.

Comment 5

[[e-mail] (:bhearsum)]

I don't think we've seen this for ages.