588407 - Bug 130078 causes some fonts to be aliased

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Matheus Kerschbaum]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100817 Minefield/4.0b5pre
Build Identifier: 

See http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/?C=M;O=D with a build from Bug 130078. Result: http://img841.imageshack.us/img841/8617/82319408.png (from https://bugzilla.mozilla.org/show_bug.cgi?id=130078#c132)

Reproducible: Always

Comment 1

[Timothy Nikkel (:tnikkel)]

So I guess we are not getting an opaque surface to draw the text on?

Comment 2

[Gábor Stefanik]

That's my guess too. The rendering looks curiously like bug 363861.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Gabor: does the problem go away if you zoom?

Timothy, you probably need to be wrapping all toplevel content documents in a container layer if you aren't already (not just when zooming).

Comment 4

[Gábor Stefanik]

I don't know as I haven't tested it, I'm just basing my comments on the pictures.

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: put top level content documents in a container layer

I had a patch for this sitting in my queue.

Let's try it and see if it fixes this issue.

Comment 6

[Gábor Stefanik]

Perhaps we should note (e.g. in a comment) that this is a workaround for bug 363861 - or is a container layer also needed for something else?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's not really a workaround. It's the right thing to do. It ensures that we don't fold Web content into the same layers as chrome, which is a good idea since the Web content is going to change a lot.

Comment 8

[Timothy Nikkel (:tnikkel)]

Kurt, you reported this in bug 130078, comment 132. Can you try this try server build to see if the issue is fixed for you?

http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-2050d6216b77/

Comment 9

[u88484]

(In reply to comment #8)
> Kurt, you reported this in bug 130078, comment 132. Can you try this try server
> build to see if the issue is fixed for you?
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-2050d6216b77/

Looks great!

Comment 10

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/e1036a654d08

Comment 11

[Timothy Nikkel (:tnikkel)]

The link to the try server build I posted above (2050d6216b77) was incorrect, it did not have 130078.

Please try one of these try server builds to see if the problem is resolved
http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-cf64eea45e07/

Comment 12

[u88484]

(In reply to comment #11)
> The link to the try server build I posted above (2050d6216b77) was incorrect,
> it did not have 130078.
> 
> Please try one of these try server builds to see if the problem is resolved
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-cf64eea45e07/

Still aliased http://img825.imageshack.us/img825/9766/28229865.png

Comment 13

[Timothy Nikkel (:tnikkel)]

Do we need bug 574621 maybe? I haven't been included it in my try pushes because of the failures mentioned in that bug and it not fixing anything user visible that I know of.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes, I think we will.

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Bug 579276 might fix this too.

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I see this. Plain text files lack subpixel AA, because the ThebesLayer for the content is treated as transparent. I think it's simply bug 574621.

Comment 17

[Timothy Nikkel (:tnikkel)]

Bug 130078 landed and this issue should be fixed. The latest nightly can be used to test. If it is not fixed then please reopen.

Comment 18

[u88484]

(In reply to comment #17)
> Bug 130078 landed and this issue should be fixed. The latest nightly can be
> used to test. If it is not fixed then please reopen.

Looks fine with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100827 Firefox/4.0b5pre

Mark verified if that is the nightly that should contain the patches you mentioned.

Comment 19

[Timothy Nikkel (:tnikkel)]

2010-08-28 would be the first nightly with bug 130078.

Comment 20

[u88484]

Verifiying fixed 

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100829 Firefox/4.0b5pre

Comment 21

[Mikko Rantalainen]

Could bug 590864 be related to this one? Testing with Mozilla/5.0 (X11; Linux x86_64; rv:2.0b5pre) Gecko/20100830 Firefox/4.0b5pre seems to still have issues with font antialiasing.