Closed Bug 588410 Opened 9 years ago Closed 9 years ago

make install doesn't work with omnijar

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: chrisccoulson, Assigned: chrisccoulson)

Details

Attachments

(1 file)

Our Ubuntu daily builds from mozilla-central are currently failing since the introduction of http://hg.mozilla.org/mozilla-central/rev/5ca9e053ee98.

What is happening is that "make install" is installing all the uncompressed chrome in to the chrome/ folder, and no omni.jar is being created anywhere in the build.

Talking to bsmedberg on IRC:

<chrisccoulson> hi, we've just got the omnijar changes in our ubuntu daily builds, and i'm not sure if i'm missing something in the build, but "make install" is installing lots of unpacked files in chrome/ , and there is no omni.jar file being created anywhere
 i assume that's not expected is it?
<bsmedberg> no
 doesn't make install do `make package` and then unpack it?
 oh, no it doesn't
 it does stage-package and then hand-installs stuff
<bsmedberg> chrisccoulson: is this FF-on-XR, or standalone?
<bsmedberg> FF-on-XR probably shouldn't be using omnijar
<chrisccoulson> bsmedberg,  this is standalone (if, by "standalone" you mean that we're building it with all the internal bundled libraries)
 should i not use make install for our builds?
<bsmedberg> I'm mean not on a separate xulrunner.
<chrisccoulson> yeah, we don't use a separate xulrunner anymore in ubuntu
<bsmedberg> make install probably needs to be fixed
 It's certainly not something that we actively test.
Here is a patch which I'm currently using in our Ubuntu nightly builds. It adds an extra step to the install target to build the omni.jar after running stage-package
Assignee: nobody → chrisccoulson
Attachment #476775 - Flags: review?(benjamin)
Attachment #476775 - Flags: review?(benjamin) → review+
Attachment #476775 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/4f11a96707f7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.