588456 - IME doesn't commit properly when losing focus on Android

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

When a textbox loses focus on Android, the text is not committed properly.

This leads to problems such as decorations (underlines, coloring) staying in the textbox even after focus is lost.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Another symptom of this problem is that you move focus from one text field to another, the second text field will receive the commit event and get the text you had intended to enter in the first

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Patch v1

Patch fixes all previous symptoms.

Because we have to commit the composition during ResetInputState, it's easier to just keep a copy of the composition text, rather than to query Java code for it. nsWindow::DispatchEvent is used instead of nsWindow::OnIMEEvent because e10s code calls DispatchEvent directly.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Patch v2

Moved input connection reset to GeckoSurfaceView.onCreateInputConnection. No change in functionality.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 467507 [details] [diff] [review]
Patch v2

Looks good!

Comment 5

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/4d5b0a8216a7

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This landed on the relbranch, which was almost certainly not what you wanted.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Or maybe it was :-)

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

it should land on both