588461 - cfx xpi is creating zip files with directories that contain bad permission attributes

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

When running 'cfx xpi' on the addons builder helper project, for instance, and then unzipping the generated xpi into a directory called 'p', and then running 'rm -rf p', we get:

rm: p/resources/jid0-t3eerqgganlch9c50lpqctdunng-addons-builder-helper-data: Permission denied
rm: p/resources/jid0-t3eerqgganlch9c50lpqctdunng-addons-builder-helper-lib: Permission denied
rm: p/resources/jid0-t3eerqgganlch9c50lpqctdunng-addons-builder-helper-tests: Permission denied
rm: p/resources/jid0-t3eerqgganlch9c50lpqctdunng-development-mode-lib: Permission denied
rm: p/resources/jid0-t3eerqgganlch9c50lpqctdunng-jetpack-core-data: Permission denied
rm: p/resources/jid0-t3eerqgganlch9c50lpqctdunng-jetpack-core-lib: Permission denied
rm: p/resources/jid0-t3eerqgganlch9c50lpqctdunng-test-harness-data: Permission denied
rm: p/resources/jid0-t3eerqgganlch9c50lpqctdunng-test-harness-lib: Permission denied
rm: p/resources: Directory not empty
rm: p: Directory not empty

This is because those directories in question have permissions of 0000, i.e. 'd---------'.

This should be fixed so these directories have permissions of at least 0755, or 'drwxr-xr-x'.

Comment 1

[Atul Varma [:atul]]

Attachment: patch, no unit tests though.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 467049 [details] [diff] [review]
patch, no unit tests though.

r=myk, and a0.7=myk for landing during freeze

Comment 3

[Atul Varma [:atul]]

Pushed: 

Bug 588461 - cfx xpi is creating zip files with directories that contain bad permission attributes
Atul Varma [:atul]
http://hg.mozilla.org/labs/jetpack-sdk/rev/fe005b3aff5a

Comment 4

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".