NetworkPanel: Display submitted form data formated

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Julian Viereck, Assigned: Julian Viereck)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kd4b5])

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

8 years ago
Created attachment 467138 [details] [diff] [review]
Patch v1

Currently, when you inspect a network requests that sent some data to the server as form data, the form data is show only as ugly to read string (they way it's sent to the server). Tree the case of sending form data to the server special and format the data in key: value pairs.
Attachment #467138 - Flags: feedback?(ddahl)

Comment 1

8 years ago
Comment on attachment 467138 [details] [diff] [review]
Patch v1

Is there a function called _setI10N in the network panel patch? shouldn't it be setL10N?

Otherwise looks good.
Attachment #467138 - Flags: feedback?(ddahl) → feedback+
(Assignee)

Comment 2

8 years ago
Created attachment 467517 [details] [diff] [review]
Patch v1.1

Rebased patch.
Attachment #467138 - Attachment is obsolete: true
Attachment #467517 - Flags: review?(dietrich)
(Assignee)

Updated

8 years ago
Blocks: 587574
(Assignee)

Updated

8 years ago
Attachment #467517 - Flags: review?(dietrich) → review?(sdwilsh)
Comment on attachment 467517 [details] [diff] [review]
Patch v1.1

>+    let fromDataRegExp = /Content-Type\:\s+application\/x-www-form-urlencoded/;
I think you want to cache this globally (compiling regular expressions isn't exactly cheap).

Also, per RFC 822 (http://tools.ietf.org/html/rfc822#section-3.1.2), a space after the colon is not necessary, so the regular expression should be: /Content-Type\:\s*application\/x-www-form-urlencoded/
A test for the no whitespace case should also be added.

r=sdwilsh with those changes
Attachment #467517 - Flags: review?(sdwilsh) → review+

Updated

8 years ago
Whiteboard: [kd4b5]
(Assignee)

Comment 4

8 years ago
Created attachment 469443 [details] [diff] [review]
Patch v2

Improved based on Shawn's latest feedback. Also converted from HTML to XHTML + DTD.
Attachment #467517 - Attachment is obsolete: true
Attachment #469443 - Flags: review?(sdwilsh)
(Assignee)

Comment 5

8 years ago
Created attachment 469885 [details] [diff] [review]
Patch v2.1

Rebased version.
Attachment #469443 - Attachment is obsolete: true
Attachment #469885 - Flags: review?(sdwilsh)
Attachment #469443 - Flags: review?(sdwilsh)
Comment on attachment 469885 [details] [diff] [review]
Patch v2.1

r=sdwilsh
Attachment #469885 - Flags: review?(sdwilsh) → review+

Updated

8 years ago
Attachment #469885 - Flags: approval2.0+
(Assignee)

Comment 7

8 years ago
Created attachment 470110 [details] [diff] [review]
[backed-out] Patch v2.1.1

Rebased patch.
Attachment #469885 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed

Comment 8

8 years ago
This bug blocks 587574, which is a blocker
Comment on attachment 470110 [details] [diff] [review]
[backed-out] Patch v2.1.1

http://hg.mozilla.org/mozilla-central/rev/95ed0bd8f88b
Attachment #470110 - Attachment description: Patch v2.1.1 → [checked-in] Patch v2.1.1
Comment on attachment 470110 [details] [diff] [review]
[backed-out] Patch v2.1.1

http://hg.mozilla.org/mozilla-central/rev/289e6da90526

leaks.
Attachment #470110 - Attachment description: [checked-in] Patch v2.1.1 → [backed-out] Patch v2.1.1

Comment 11

8 years ago
http://hg.mozilla.org/mozilla-central/rev/ce7602d990f9

after try server success, one more push
Keywords: checkin-needed

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.