588550 - Titlebar area becomes black when dragging bottom window frame into it

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[hjalte]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100818 Minefield/4.0b5pre Firefox/3.6.8
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100818 Minefield/4.0b5pre Firefox/3.6.8

With the latest nightly, the glass titlebar area at the top of the window becomes black when the window is scrunched vertically so that the bottom frame overlaps it.

Reproducible: Always

Comment 1

[hjalte]

Attachment: Screenshot

Comment 2

[Rob Arnold [:robarnold]]

I can confirm this though I do not yet know why it is happening.

Comment 4

[hjalte]

I am not convinced that this is a duplicate of bug 574957 as this particular problem did not exist until this very nightly as far as I can tell.  In fact, I think it could be connected with bug 554982, which messed with the glass borders.  Also, this happens even when the page is devoid of any flash or other plugin content.

Comment 5

[Rob Arnold [:robarnold]]

This is not a dupe as it happens with a new window and about:blank - thus w/o plugins.

Comment 6

[Rob Arnold [:robarnold]]

This bug happens due to incorrect margin calculations. Easy fix.

Comment 7

[Rob Arnold [:robarnold]]

Attachment: Don't adjust margins for borderless glass if the entire window is glass

Nice one line patch :)

Comment 8

[Rob Arnold [:robarnold]]

Comment on attachment 467270 [details] [diff] [review]
Don't adjust margins for borderless glass if the entire window is glass

Requsting approval. This was a silly little regression from bug 554982.

Comment 9

[Joe Drew (not getting mail)]

Comment on attachment 467270 [details] [diff] [review]
Don't adjust margins for borderless glass if the entire window is glass

Easy approval. I might even have blocked on this!

Comment 10

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/4cf06104570a