588568 - Reported crash in about:memory on XP [@ D2DVRAMReporter::GetMemoryUsed(__int64*) ]

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Bas Schouten (:bas.schouten)]

We have a report of about:memory crashing on XP.

crash-report : bp-1703b36b-898a-4c8f-abcc-493252100818

Comment 1

[Jo Hermans]

that's on hardware that isn't Direct2D capable if that helps

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: Only check VRAM if we have a D2D Device

Comment 3

[Bas Schouten (:bas.schouten)]

Attachment: Only check VRAM if we have a D2D Device v2

Updated to make sure 0 is returned otherwise.

Comment 4

[Bas Schouten (:bas.schouten)]

(In reply to comment #1)
> that's on hardware that isn't Direct2D capable if that helps

Windows XP doesn't support Direct2D at all :-) Regardless of the hardware. It has no DirectX 10 support.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 467182 [details] [diff] [review]
Only check VRAM if we have a D2D Device v2

This would be easier to read if you did:

device = gfxWindowsPlatform::GetPlatform()->GetD2DDevice()
if (device) {
} else {
}

Comment 6

[Bas Schouten (:bas.schouten)]

Attachment: Only check VRAM if we have a D2D Device v3

Make it look prettier like Jeff suggested :-).

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/2acf7d0d9c47

Comment 8

[Jo Hermans]

Mozilla/5.0 (Windows NT 5.1; rv:2.0b5pre) Gecko/20100819 Minefield/4.0b5pre

verified in latest nightly : it doesn't crash anymore, and shows 0 for gfx/d2d/surfacevram