588639 - overriding getter with properties are failing in custom ES5 implementation

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Due to a implementation bug overriding getter or inherited getter with the same named properties are failing.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: fix

http://github.com/Gozala/jetpack-sdk/commit/c9e46b9a69e6496580678ae1c5006cef6883fbc8

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 467242 [details] [diff] [review]
fix

r=myk, but note nits on github commit page.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Addressing review commets

Since I changes in iterator behavior where affecting this, I had to remove few  changes and this patch is considered to be on top of https://bugzilla.mozilla.org/show_bug.cgi?id=588636

commit link: http://github.com/Gozala/jetpack-sdk/commit/d3e52363a4ae727f0f3c8e98a219975ce87de0ab

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Addressing review commets

Last patch on 588636 have affected this change so had to update this patch to sync
Please note that this goes on top of: 588636

Link: http://github.com/Gozala/jetpack-sdk/commit/dcd7dd3a3a29e60c8ea0bb0915257e0025c0cb5f

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 469009 [details] [diff] [review]
Addressing review commets

Sorry for the delay reviewing this, it looks great! r=myk

Comment 6

[Myk Melez [:myk] [@mykmelez]]

checkin-needed, but depends on bug 588636.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/3ce007313e2c.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".