if we can't paint with widget layers, don't try to

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 467318 [details] [diff] [review]
patch

As bug 587539 shows PaintFrame can be called without a widget, so the assertion at the start of the function fires. This causes some mac reftests with plugins to fail. I added this assertion recently, so I think we should just make it a warning.
Attachment #467318 - Flags: review?(roc)
How about removing USE_WIDGET_LAYERS in this case to ensure that the rendering still works?
(Assignee)

Comment 2

9 years ago
Created attachment 467331 [details] [diff] [review]
remove the flag

Okay, let's do that.
Assignee: nobody → tnikkel
Attachment #467318 - Attachment is obsolete: true
Attachment #467331 - Flags: review?(roc)
Attachment #467318 - Flags: review?(roc)
(Assignee)

Updated

9 years ago
Summary: assertion in nsLayoutUtils::PaintFrame should be warning → if we can't paint with widget layers, don't try to
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/mozilla-central/rev/33bd84f0b181
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.