Closed Bug 588719 Opened 9 years ago Closed 9 years ago

remove nsVIQRToUnicode, nsVNIToUnicode, nsUnicodeToVIQR, nsUnicodeToVNI, and nsUnicodeToISO2022KR

Categories

(Core :: Internationalization, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file, 2 obsolete files)

/usr/bin/ranlib: file: libucvlatin_s.a(nsVIQRToUnicode.o) has no symbols
/usr/bin/ranlib: file: libucvlatin_s.a(nsVNIToUnicode.o) has no symbols
/usr/bin/ranlib: file: libucvlatin_s.a(nsUnicodeToVIQR.o) has no symbols
/usr/bin/ranlib: file: libucvlatin_s.a(nsUnicodeToVNI.o) has no symbols
ranlib: file: libucvlatin_s.a(nsVIQRToUnicode.o) has no symbols
ranlib: file: libucvlatin_s.a(nsVNIToUnicode.o) has no symbols
ranlib: file: libucvlatin_s.a(nsUnicodeToVIQR.o) has no symbols
ranlib: file: libucvlatin_s.a(nsUnicodeToVNI.o) has no symbols
/usr/bin/ranlib: file: libucvko_s.a(nsUnicodeToISO2022KR.o) has no symbols
ranlib: file: libucvko_s.a(nsUnicodeToISO2022KR.o) has no symbols
Attached patch patch (obsolete) — Splinter Review
Assignee: smontagu → timeless
Status: NEW → ASSIGNED
Attachment #467357 - Flags: review?(smontagu)
Comment on attachment 467357 [details] [diff] [review]
patch

You need to remove the CIDs and (except for iso-2022-kr) charset aliases as well.
Attachment #467357 - Flags: review?(smontagu) → review-
Attachment #467357 - Attachment is obsolete: true
Attachment #494460 - Flags: review?(smontagu)
Attachment #494460 - Flags: approval2.0?
Comment on attachment 494460 [details] [diff] [review]
remove more defines and charset aliases

Remove also http://mxr.mozilla.org/mozilla-central/source/intl/uconv/src/charsetalias.properties#150 "x-viet-vni=x-viet-vni" and you're done.

r=me with that
Attachment #494460 - Flags: review?(smontagu) → review+
Attachment #494460 - Attachment is obsolete: true
Attachment #494480 - Flags: review+
Attachment #494480 - Flags: approval2.0?
Attachment #494460 - Flags: approval2.0?
Attachment #494480 - Flags: approval2.0? → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/901f41d1142e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.