588728 - List base class representing enumerable collections (part of sidebar)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Implementation + Documentation + Tests

Branch for this issue is:
http://github.com/Gozala/jetpack-sdk/tree/list@588728

It has changes on top of https://bugzilla.mozilla.org/show_bug.cgi?id=588732
even though it doesn't really depends on it. There for all the changes can be viewed on:
http://github.com/Gozala/jetpack-sdk/compare/events@588732...list@588728

Commit including this changes for easy comments is here:
http://github.com/Gozala/jetpack-sdk/commit/c9571bc77f48a5a6a620fd202783659c66a07ebc

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 470408 [details] [diff] [review]
Implementation + Documentation + Tests

This looks great.  The only issue is that currently all of our "private" modules are mixed in with the rest of the modules in the lib/ directory, and I would like to decouple the decision as to whether or not to move them into a private/ subdirectory from this change.

In other words, this change should land the modules in the lib/ directory, and then we can figure out whether or not to move all such modules into a private/ subdirectory as a separate change (which happens to be bug 571285).

r=myk with that change.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Chageing path of module + minor change

Have changed the path + added tiny change: http://github.com/Gozala/jetpack-sdk/commit/5b81935d8db5789527c659fe961583f46ef62bb3

Had to do that since native Function.prototype.bind was landed into nightly and with native version stack is different.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 471477 [details] [diff] [review]
Chageing path of module + minor change

This has the events changes mixed in with it, and the list.md file is still in a private/ subdirectory (and references the `"private/list"` module instead of simply the `list` module).

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: moving docs and fixing reference to the module

Oops forgot about docs.

Comment 6

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

link to the commit: http://github.com/Gozala/jetpack-sdk/commit/58fd6a619c20ee13a1cbcf21328260797af33bc9
and branch with all the changes:
http://github.com/Gozala/jetpack-sdk/commits/list%40588728

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 472749 [details] [diff] [review]
moving docs and fixing reference to the module

This looks pretty good, just some minor nits and a couple issues.  Comments are on the GitHub commit page <http://github.com/Gozala/jetpack-sdk/commit/58fd6a619c20ee13a1cbcf21328260797af33bc9>.

Comment 8

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Addressing review commets

Full diff: http://github.com/Gozala/jetpack-sdk/commit/2f74d8e5319747dfecf6d7a863559e96b09a5900

Changes from last: http://github.com/Gozala/jetpack-sdk/commit/7f13e3bec27414f2550a433581f197d5dbc0f075

Feature branch: http://github.com/Gozala/jetpack-sdk/commits/list%40588728

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 473476 [details] [diff] [review]
Addressing review commets

Looks good, r=myk!

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/51becd21b53a.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".