588794 - Conditional jump or move depends on uninitialised value(s) [@ CSSLoaderImpl::ParseSheet]

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mats Palmgren (inactive)]

Attachment: Valgrind message

Conditional jump or move depends on uninitialised value(s) [@ CSSLoaderImpl::ParseSheet]

Affects 1.9.2 and 1.9.1, not trunk

Comment 1

[Mats Palmgren (inactive)]

Attachment: fix

The typo fix is to make -DDEBUG_TRACEMALLOC_PRESARENA compile.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 467432 [details] [diff] [review]
fix

r=dbaron

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This seems like something that could break any chrome style sheets that have a syntax error in the first rule, which could be a problem for some extensions.  Seems like something we should get in to the branch soon.

It's a regression from bug 524223.

Comment 4

[LegNeato]

This would not block a release, but we would like to fix it as it is a regression. Feel free to nominate for for 3.6.10 and 3.5.13 when it is ready.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 467432 [details] [diff] [review]
fix

Approved for 1.9.2.10 and 1.9.1.13, a=dveditz for release-drivers

Comment 6

[Mats Palmgren (inactive)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/bc021a2ec6a9
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2e3179e393e3

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/05acd6e91c43

Comment 7

[Al Billings [:abillings - ex-MoCo]]

Is there anything for QA to do to verify this on branch?

Comment 8

[Mats Palmgren (inactive)]

(In reply to comment #7)
> Is there anything for QA to do to verify this on branch?

Probably not, you need a special build (ac_add_options --enable-valgrind)
and then run unit tests under valgrind to see the reported error.

Maybe it's possible to make a testcase based on comment 3, I don't know.