589098 - Add-ons manager cannot restart xulrunner-based apps because Application is undefined

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Following checkin for bug 567127, I rebuilt BlueGriffon, my own xulrunner-based app and tried the new Install Add-on UI. It works fine BUT is unable to restart my app because |Application| is undefined in extensions.js line 361.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Added a workaround to https://developer.mozilla.org/en/XULRunner_tips
Maybe this is enough and this bug is a WONTFIX. Blair, you decide.

Comment 2

[Dave Townsend [:mossop]]

THe restart messages are pretty basic functionality and should work everywhere. I guess we'll just need to stop using the FUEL wrapper for it.

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to comment #2)
> THe restart messages are pretty basic functionality and should work everywhere.
> I guess we'll just need to stop using the FUEL wrapper for it.

Not sure. Forcing to use the workaround I documented is a good way of
centralizing this feature inside the Application "helper". That way, making
it evolve later is easier, including for xulrunner-based apps.
Just my 2 eurocents.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Not related to bug 567127 - this is an issue anywhere the addons manager prompts to restart.

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 474302 [details] [diff] [review]
patch rev 1

>+        return true;

Nit: Not needed.

Comment 7

[Dave Townsend [:mossop]]

landed: http://hg.mozilla.org/mozilla-central/rev/6e12dfb03f56

Needs manual testing that restarts still work.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Daniel, can you please verify the fix with a latest version of XulRunner which has this fix included? Thanks.

Dave, how should a manual test look like? We only cover Firefox in our tests on Litmus.

Comment 9

[Dave Townsend [:mossop]]

(In reply to comment #8)
> Daniel, can you please verify the fix with a latest version of XulRunner which
> has this fix included? Thanks.
> 
> Dave, how should a manual test look like? We only cover Firefox in our tests on
> Litmus.

The only way to really verify that this works in other applications would be to try it out in other applications. That isn't something we've traditionally done for other fixes though.

Comment 10

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to comment #8)
> Daniel, can you please verify the fix with a latest version of XulRunner which
> has this fix included? Thanks.

Will test today. Thanks.

Comment 11

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to comment #8)
> Daniel, can you please verify the fix with a latest version of XulRunner which
> has this fix included? Thanks.

Just rebuilt after a hg pull -u...
The result is... "cannot tell" because of bug 591801 :-(
Sorry but the extension manager is totally horked for me because of that one.

But reading the code, that should be ok.

Comment 12

[Florian Quèze [:florian]]

I can confirm that this bug is fixed in Instantbird.

(We are also annoyed by bug 591801. We worked around it temporarily by doing a partial local backout of the patch from bug 562797.)

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Florian! Given that information we can set move the status to verified fixed. I will still have to think about the requested manual test...

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On Litmus we do not cover any other application as our supported ones. But, on Ubuntu Firefox is built on top of XULrunner, which means that our various existing tests should cover this specific issue. Dave, if you think it's not the case, the request should be declined.