589159 - reduce unused variable warnings during build

Status: RESOLVED DUPLICATE of bug 577899

(Core :: XPCOM, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

In several places in our code we set a return value to a variable but only check it in a debug assert, which produces warnings in release builds.

This patch adds an NS_IF_DEBUG macro which can be used to wrap those assignments, for example:

NS_IF_DEBUG(nsresult rv =) NS_DO_SOMETHING(foo, bar);

It also uses it where appropriate. It passed try for all the builders, there is an orange reftest that I need to investigate though.

Benjamin, I'm not sure if you can review this sort of across the board change or not, let me know.

Comment 1

[Benjamin Smedberg]

This was already discussed and WONTFIXed in bug 577899.