Closed Bug 589175 Opened 9 years ago Closed 9 years ago

Omnijar warning: "cannot load binary components..."

Categories

(Firefox Build System :: General, defect)

x86
All
defect
Not set

Tracking

(blocking2.0 final+)

RESOLVED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- final+

People

(Reporter: ddahl, Assigned: mwu)

References

Details

Attachments

(1 file, 2 obsolete files)

today's build is saying this:

Warning: Cannot load binary components from the omnijar.
Source File: C:\Users\ddahl\bin\firefox\omni.jar:components/components.manifest
Line: 107

Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre
It's a relatively harmless warning. The packaging for omnijar generates another set of manifests to point to binary components so they do end up being loaded outside of the omnijar. Should get rid of this warning one way or another though.
Duplicate of this bug: 589087
Wait, doesn't it remove the directive from the in-omnijar manifests? It should!
Assignee: nobody → mwu
blocking2.0: --- → final+
Summary: Omnijar error: "cannot load binary components..." → Omnijar warning: "cannot load binary components..."
Attachment #468416 - Flags: review?(benjamin)
Attachment #468416 - Flags: review?(benjamin) → review+
Attached patch hg patch ready patch (obsolete) — Splinter Review
Attachment #468416 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/9f8fc8a50525
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5
This patch broke the Windows builds.  Apparently it was never tested on try.  Please do make sure to test the new version of the patch on try server before marking it as checkin-needed.

Sample log:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1282921760.1282921760.10529.gz

Backout:
http://hg.mozilla.org/mozilla-central/rev/ccd462cc196d
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This one is uglier but works on windows.
Attachment #469702 - Attachment is obsolete: true
Passed try.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/ea9e5837cf6d
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: mozilla2.0b5 → mozilla2.0b6
Version: unspecified → Trunk
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.