today's build is saying this: Warning: Cannot load binary components from the omnijar. Source File: C:\Users\ddahl\bin\firefox\omni.jar:components/components.manifest Line: 107 Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre
It's a relatively harmless warning. The packaging for omnijar generates another set of manifests to point to binary components so they do end up being loaded outside of the omnijar. Should get rid of this warning one way or another though.
Wait, doesn't it remove the directive from the in-omnijar manifests? It should!
Created attachment 468416 [details] [diff] [review] Comment out binary-component entries
Created attachment 469702 [details] [diff] [review] hg patch ready patch
This patch broke the Windows builds. Apparently it was never tested on try. Please do make sure to test the new version of the patch on try server before marking it as checkin-needed. Sample log: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1282921760.1282921760.10529.gz Backout: http://hg.mozilla.org/mozilla-central/rev/ccd462cc196d
Created attachment 470669 [details] [diff] [review] hg patch ready patch, v2 This one is uglier but works on windows.