589175 - Omnijar warning: "cannot load binary components..."

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[David Dahl :ddahl]

today's build is saying this:

Warning: Cannot load binary components from the omnijar.
Source File: C:\Users\ddahl\bin\firefox\omni.jar:components/components.manifest
Line: 107

Mozilla/5.0 (Windows NT 6.1; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre

Comment 1

[Michael Wu [:mwu]]

It's a relatively harmless warning. The packaging for omnijar generates another set of manifests to point to binary components so they do end up being loaded outside of the omnijar. Should get rid of this warning one way or another though.

Comment 3

[Benjamin Smedberg]

Wait, doesn't it remove the directive from the in-omnijar manifests? It should!

Comment 4

[Michael Wu [:mwu]]

Attachment: Comment out binary-component entries

Comment 5

[Michael Wu [:mwu]]

Attachment: hg patch ready patch

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/9f8fc8a50525

Comment 7

[(no longer active)]

This patch broke the Windows builds.  Apparently it was never tested on try.  Please do make sure to test the new version of the patch on try server before marking it as checkin-needed.

Sample log:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1282921760.1282921760.10529.gz

Backout:
http://hg.mozilla.org/mozilla-central/rev/ccd462cc196d

Comment 8

[Michael Wu [:mwu]]

Attachment: hg patch ready patch, v2

This one is uglier but works on windows.

Comment 9

[Michael Wu [:mwu]]

Passed try.

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/ea9e5837cf6d