Closed Bug 589194 Opened 14 years ago Closed 14 years ago

Make twinopen work when XUL is disabled

Categories

(Testing :: Talos, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sicking, Assigned: anodelman)

References

Details

Attachments

(2 files)

twinopen is failing if all patches in bug 546857 are checked in. It seems like it's loading a XUL file from a non-chrome:// address. This is fine, but means that we need to set up a permissions.sqlite database in the profile that twinopen runs with. I've already done similar things for reftest and mochitest.
FWIW, the code used by mochitest and reftest to set up the permissions.sqlite database lives here:

http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#293
Attachment #467837 - Attachment is patch: false
Attachment #467837 - Attachment mime type: text/plain → application/octet-stream
I can put this patch together.
Is the filename 'permissions.sqlite' correct?  Does it just go in the main profile directory or does it have another path?
In main path and name is correct yes.
Not much to review here, but might as well get a stamp.
Assignee: nobody → anodelman
Attachment #467931 - Flags: review?(jhammel)
For what it's worth, the patch looks good to me
Comment on attachment 467931 [details] [diff] [review]
add permissions.sqlite file to built in talos profiles

not really sure how to review this, but nothing here is objectionable
Attachment #467931 - Flags: review?(jhammel) → review+
This should be included in the next releng downtime.
Depends on: 588896
Comment on attachment 467931 [details] [diff] [review]
add permissions.sqlite file to built in talos profiles

</var/folders/n4/n4JUOnN3ETmS1p+ANEVzik+++TM/-Tmp-/cvsA43RHd" 13L, 608C written
RCS file: /cvsroot/mozilla/testing/performance/talos/base_profile/permissions.sqlite,v
done
Checking in base_profile/permissions.sqlite;
/cvsroot/mozilla/testing/performance/talos/base_profile/permissions.sqlite,v  <--  permissions.sqlite
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/mobile_profile/permissions.sqlite,v
done
Checking in mobile_profile/permissions.sqlite;
/cvsroot/mozilla/testing/performance/talos/mobile_profile/permissions.sqlite,v  <--  permissions.sqlite
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/places_generated_max/permissions.sqlite,v
done
Checking in places_generated_max/permissions.sqlite;
/cvsroot/mozilla/testing/performance/talos/places_generated_max/permissions.sqlite,v  <--  permissions.sqlite
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/places_generated_med/permissions.sqlite,v
done
Checking in places_generated_med/permissions.sqlite;
/cvsroot/mozilla/testing/performance/talos/places_generated_med/permissions.sqlite,v  <--  permissions.sqlite
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/places_generated_min/permissions.sqlite,v
done
Checking in places_generated_min/permissions.sqlite;
/cvsroot/mozilla/testing/performance/talos/places_generated_min/permissions.sqlite,v  <--  permissions.sqlite
initial revision: 1.1
done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: