589355 - IndexedDB: Add IDBObjectStore::Clear

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

For clearing object stores.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 467974 [details] [diff] [review]
Patch, v1

>+ClearHelper::DoDatabaseWork(mozIStorageConnection* aConnection)
>+{
>+  NS_PRECONDITION(aConnection, "Passed a null connection!");
>+
>+  nsCString table;
>+  if (mAutoIncrement) {
>+    table.AssignLiteral("ai_object_data");
>+  }
>+  else {
>+    table.AssignLiteral("object_data");
>+  }
>+
>+  NS_NAMED_LITERAL_CSTRING(osid, "osid");
>+
>+  nsCString query = NS_LITERAL_CSTRING("DELETE FROM ") + table +
>+                    NS_LITERAL_CSTRING(" WHERE object_store_id = :") + osid;

This will create needless string concatenation. If you don't want to duplicate the string "osid" (which IMHO would be ok to duplicate), then use a #define or some such.

You should test that clearing a objectStore does *not* reset its autoincrement counter.

r=me with that.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1.1

With comments addressed.

Requesting approval for spec compliance. Has tests.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/c37dead0da88