Closed Bug 589371 Opened 11 years ago Closed 11 years ago
Error from being inlined
FatalError is currently being inlined, on GCC/OS X at least. This prevent us from seeing which IPC message is causing the error. For example in this report: http://crash-stats.mozilla.com/report/index/7c31b4f1-4780-4fc1-967f-835c12100819
Make FatalError virtual to prevent inlining rather then using compiler specific noinline attribute. This should have no performance implication.
Assignee: nobody → b56girard
Status: NEW → ASSIGNED
Attachment #467988 - Flags: review?
Attachment #467988 - Flags: review? → review?(jones.chris.g)
11 years ago
Attachment #467988 - Flags: review?(jones.chris.g) → review+
I will land this Saturday (wont be home to watch the tree today).
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/rev/3e1939477d6d NOTE: I incorrectly listed Josh as the patch reviewer, it should of been cjones.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.