Closed
Bug 589371
Opened 15 years ago
Closed 15 years ago
Prevent FatalError from being inlined
Categories
(Core :: IPC, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file)
|
1.33 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
FatalError is currently being inlined, on GCC/OS X at least. This prevent us from seeing which IPC message is causing the error. For example in this report:
http://crash-stats.mozilla.com/report/index/7c31b4f1-4780-4fc1-967f-835c12100819
|
Assignee | |
Comment 1•15 years ago
|
||
Make FatalError virtual to prevent inlining rather then using compiler specific noinline attribute. This should have no performance implication.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #467988 -
Flags: review? → review?(jones.chris.g)
|
||
Updated•15 years ago
|
Attachment #467988 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Updated•15 years ago
|
Attachment #467988 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
blocking2.0: --- → betaN+
|
|
Assignee | |
Comment 2•15 years ago
|
||
I will land this Saturday (wont be home to watch the tree today).
|
|
Assignee | |
Updated•15 years ago
|
Attachment #467988 -
Flags: approval2.0?
|
|
Assignee | |
Comment 3•15 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/3e1939477d6d
NOTE: I incorrectly listed Josh as the patch reviewer, it should of been cjones.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•