589391 - ensure proper minimum Mac OS X system version is set for each architecture

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Josh Aas]

Attachment: fix v1.0

Currently if you try to run an i386/x86_64 universal binary on Mac OS X 10.5 you'll get a crash when the OS tries to run the x86_64 component of the universal binary, which it does by default. We need to use "LSMinimumSystemVersionByArchitecture" to specify the minimum OS version for each architecture.

"LSMinimumSystemVersionByArchitecture" can be safely used in conjunction with the more general "LSMinimumSystemVersion".

Comment 1

[Josh Aas]

Note, there shouldn't be any problem specifying the minimum required OS for both i386 and x86_64 even when a binary is not universal and contains only one architecture.

Comment 2

[Josh Aas]

Hmm, this doesn't solve the problem for x86_64-only binaries on 10.5. Apparently "LSMinimumSystemVersionByArchitecture" is not used when the binary is not universal. It doesn't do any harm to have it there, but it doesn't fix the the non-universal x86_64 on 10.5 problem.

Comment 3

[Josh Aas]

Apparently nothing fixes the non-universal x86_64 on 10.5 problem. No combination of "LSMinimumSystemVersion" or "LSMinimumSystemVersionByArchitecture" fixes the problem so we should probably just go with my original patch.

Comment 4

[Josh Aas]

Attachment: fix v1.0 (export for check-in)

Comment 5

[[e-mail]]

Comment on attachment 468402 [details] [diff] [review]
fix v1.0 (export for check-in)

http://hg.mozilla.org/mozilla-central/rev/4d51b7d0afd9