589400 - two small fixes to talos harness

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Timothy Nikkel (:tnikkel)]

Running standalone talos I came across two things. I don't know where these files live in version control, so I'll just attach a raw diff.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: [checked in] check for existence of dir before trying to create it

Not sure who I should be asking for review.

When I made some changes to the pageloader extension and zipped them up and replaced the xpi I got an error here with a directory already existing. I think this is due to the order of the files in the zip changing. We just need to check for the existence of the directory before creating it.

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: [checked in]stop refering to non-existent css file

Not sure of who to ask for review.

There is no pageloader.css so we should stop trying to load it.

Comment 3

[Timothy Nikkel (:tnikkel)]

Note that the attached diffs are between file and file.orig, so some manual intervention will be required.

Comment 4

[alice nodelman [:alice] [:anode]]

The copy of pageloader.xpi user by talos machines will also have to be updated (after the check in, of course).

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 468012 [details] [diff] [review]
[checked in] check for existence of dir before trying to create it

Landed:
Checking in ffsetup.py;
/cvsroot/mozilla/testing/performance/talos/ffsetup.py,v  <--  ffsetup.py
new revision: 1.22; previous revision: 1.21
done

Comment 6

[[e-mail] (:bhearsum)]

I'm not certain where to apply this pageloader.xul patch. It's in CVS, m-c, 1.9.2, tracemonkey, et. al. I don't know what to do with, so that part isn't making the downtime.

Comment 7

[alice nodelman [:alice] [:anode]]

Is this still waiting on landing the pageloader change?

Comment 8

[Timothy Nikkel (:tnikkel)]

Looks like it.

Comment 9

[alice nodelman [:alice] [:anode]]

Comment on attachment 468013 [details] [diff] [review]
[checked in]stop refering to non-existent css file

changeset:   3:eab9ffc922b1

Comment 10

[alice nodelman [:alice] [:anode]]

Sorry for the long delay here, I'll make sure that it gets correctly landed.

Comment 11

[Timothy Nikkel (:tnikkel)]

Thank you Alice!

Comment 12

[Timothy Nikkel (:tnikkel)]

So this is all finished now?

Comment 13

[alice nodelman [:alice] [:anode]]

Everything is landed now.  All done.