589405 - browser.ui.zoom.pageFitGranularity preference should be 9

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Arne Petersen]

browser.ui.zoom.pageFitGranularity preference should be tweaked for Meego to prevent some webpages from downscaling by default.

Comment 1

[Jan Arne Petersen]

Attachment: Set pageFitGranularity to 9 instead of 10 on MOZ_PLATFORM_MAEMO

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I wonder if this is really maemo-only. Do you some a few websites that work better if we pagefit them?

Comment 3

[Jan Arne Petersen]

Without that patch youtube is always scaled down to 0.9 zoom level and no block zooming to 1. zoom level is possible. This makes youtube website not so good looking and also slow (because of the zooming) in software rendering case.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Matt, any thoughts on the affect of making this an ALL platform change?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Also, should we consider making a portrait vs. landscape setting?

Comment 6

[Matt Brubeck (:mbrubeck)]

(In reply to comment #4)
> Matt, any thoughts on the affect of making this an ALL platform change?

If it makes sense for MeeGo, then it makes sense everywhere.  The change seems reasonable to me; the initial 1/10 threshold was arbitrary.

I don't think portrait is important for this preference - very few sites will be close to 100% zoom in portrait, so it doesn't really matter what the threshold is.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 468017 [details] [diff] [review]
Set pageFitGranularity to 9 instead of 10 on MOZ_PLATFORM_MAEMO

r+ but drop the MAEMO only preprocessor defines.

I can make the change when landing

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/d7cac9d3ecd8