Closed Bug 589502 Opened 14 years ago Closed 13 years ago

intermittent mochitest 1/5 failure in content/base/test/test_bug421602.html Image 1 should error - got false, expected true followed by Image 2 should not error before image 1 - got true, expected false reported as though it were in another test

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0

People

(Reporter: tnikkel, Assigned: mounir)

References

Details

(Keywords: intermittent-failure, Whiteboard: [see comment 482])

Attachments

(1 file, 1 obsolete file)

Patch v2
1.90 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1282440839.1282442535.24503.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test mochitests-1/5 on 2010/08/21 18:33:59
24440 INFO TEST-START | /tests/content/base/test/test_bug421602.html
++DOMWINDOW == 33 (0x20767e58) [serial = 338] [outer = 0x1ebb34e0]
--DOMWINDOW == 32 (0x2ad5a9e8) [serial = 324] [outer = 0x2ad57ab0] [url = http://mochi.test:8888/tests/content/base/test/file_bug416317.xhtml#target]
--DOMWINDOW == 31 (0x2ad57ae8) [serial = 323] [outer = 0x0] [url = http://mochi.test:8888/tests/content/base/test/file_bug416317.xhtml#target]
--DOMWINDOW == 30 (0x2ad8a338) [serial = 326] [outer = 0x0] [url = about:blank]
--DOMWINDOW == 29 (0x2ad59868) [serial = 327] [outer = 0x0] [url = about:blank]
--DOMWINDOW == 28 (0x2ad82dc8) [serial = 325] [outer = 0x0] [url = http://mochi.test:8888/tests/content/base/test/data/iframe.html]
--DOMWINDOW == 27 (0x2ad95b48) [serial = 328] [outer = 0x0] [url = http://mochi.test:8888/tests/content/base/test/data/iframe.html]
--DOMWINDOW == 26 (0x1b99d6b8) [serial = 337] [outer = 0x1ebb34e0] [url = http://mochi.test:8888/tests/content/base/test/test_bug420700.html]
--DOMWINDOW == 25 (0x28cb6188) [serial = 336] [outer = 0x1ebb34e0] [url = http://mochi.test:8888/tests/content/base/test/test_bug420609.xhtml]
--DOMWINDOW == 24 (0x20cbad78) [serial = 329] [outer = 0x1ebb34e0] [url = http://mochi.test:8888/tests/content/base/test/test_bug416383.html]
--DOMWINDOW == 23 (0x20b7ab48) [serial = 334] [outer = 0x1ebb34e0] [url = http://mochi.test:8888/tests/content/base/test/test_bug418214.html]
--DOMWINDOW == 22 (0x19966ae8) [serial = 332] [outer = 0x0] [url = about:blank]
--DOMWINDOW == 21 (0x1997f5a8) [serial = 333] [outer = 0x0] [url = about:blank]
--DOCSHELL 0x22bc1e00 == 7
--DOMWINDOW == 20 (0x20b8ea48) [serial = 331] [outer = 0x1ebb34e0] [url = http://mochi.test:8888/tests/content/base/test/test_bug417384.html]
--DOMWINDOW == 19 (0x213b4998) [serial = 330] [outer = 0x1ebb34e0] [url = http://mochi.test:8888/tests/content/base/test/test_bug417255.html]
--DOMWINDOW == 18 (0x19ac75b8) [serial = 335] [outer = 0x1ebb34e0] [url = http://mochi.test:8888/tests/content/base/test/test_bug419527.xhtml]
24441 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug421602.html | Image 1 should error - got false, expected true
24442 INFO TEST-PASS | /tests/content/base/test/test_bug421602.html | Image 2 should error - true should equal true
24443 INFO TEST-PASS | /tests/content/base/test/test_bug421602.html | Image 1 should not load - false should equal false
24444 INFO TEST-PASS | /tests/content/base/test/test_bug421602.html | Image 2 should not load - false should equal false
24445 INFO SimpleTest finished /tests/content/base/test/test_bug421602.html in 2310ms
24446 INFO TEST-START | /tests/content/base/test/test_bug422403-1.html
24447 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_bug422403-1.html | Image 3 should not error before image 2 - got true, expected false
The two candidate reasons for it starting to fail that came up were bug 572520 and bug 563088.
Summary: intermittent mochitest 1/5 failure in content/base/test/test_bug421602.html Image 1 should error - got false, expected true and Image 2 should not error before image 1 - got true, expected false → intermittent mochitest 1/5 failure in content/base/test/test_bug421602.html Image 1 should error - got false, expected true followed by content/base/test/test_bug422403-1.html Image 2 should not error before image 1 - got true, expected false
Sympathetic though I am to sdwilsh's confusion over the summary of this bug and the confusing way it reports its second error as being in another test, it's a pain to star with one bug suggested for two different errors, and it's not like he's going to see me changing it back.
Summary: intermittent mochitest 1/5 failure in content/base/test/test_bug421602.html Image 1 should error - got false, expected true followed by content/base/test/test_bug422403-1.html Image 2 should not error before image 1 - got true, expected false → intermittent mochitest 1/5 failure in content/base/test/test_bug421602.html Image 1 should error - got false, expected true followed by Image 2 should not error before image 1 - got true, expected false reported as though it were in another test
Depends on: 565307
Attached patch Patch v1 (obsolete) — — Splinter Review 
I think this could be better but I don't understand why there is a check for error events order... So, asking the review to Boris in case of he remembers why he wrote that that way.
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #517845 - Flags: review?(bzbarsky)
> but I don't understand why there is a check for error events order

The test is meant to fail if the load event for image1 never fires.  The problem is how to detect that.

I was trying to detect it by starting a second image load after img1 and assuming that its load/error would fire after that of img1.  So if we got to image2 being loaded and had heard nothing from image1, we had the bug.

But it looks like with the async notifications the image order is not necesarily preserved (see comment 479).

I don't understand how the attached patch would help with that.

Perhaps the right thing to do is simply nix img2, end the test if either img1.onload or img.onerror files, and just let the test time out if the gc issue is regressed?
(In reply to comment #482)
> I don't understand how the attached patch would help with that.

SimpleTest.executeSoon makes img2 being created async so I guess it might help.

> Perhaps the right thing to do is simply nix img2, end the test if either
> img1.onload or img.onerror files, and just let the test time out if the gc
> issue is regressed?

I prefer that solution actually. I'm going to write a patch doing that.
Attached patch Patch v2 — — Splinter Review 

        Attachment #517845 -
        Attachment is obsolete: true

        Attachment #517950 -
        Flags: review?(bzbarsky)

        Attachment #517845 -
        Flags: review?(bzbarsky)

    
    

    
      
  

    
    

    
      
  

    
    

    
  
Comment on attachment 517950 [details] [diff] [review]
Patch v2

r=me

        Attachment #517950 -
        Flags: review?(bzbarsky) → review+

    
    

    
  
Pushed:
http://hg.mozilla.org/mozilla-central/rev/78372301e5fd

If the test still fails, please open another bug (it will obviously be another error).
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [orange] → [orange][see comment 482]
Target Milestone: --- → mozilla2.0

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  
Whiteboard: [orange][see comment 482] → [see comment 482]
Component: Event Handling → User events and focus handling

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: