589506 - Scrub the codebase of MOZ_VIEW_SOURCE and MOZ_JSLOADER

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Justin Wood (:Callek)]

(In reply to Bug 513924 comment #17)
> Comment on attachment 399009 [details] [diff] [review] [details]
> Patch v1.1
> 
>  if test "$MOZ_VIEW_SOURCE"; then
>      AC_DEFINE(MOZ_VIEW_SOURCE)
>  fi
> 
> Feels like we could just remove this completely and scrub the codebase. I'm
> fine with doing it in a followup, though.

MOZ_VIEW_SOURCE is defined everywhere now, lets kill off this define entirely

Comment 1

[Justin Wood (:Callek)]

I'll also tackle MOZ_JSLOADER in this bug.

Comment 2

[Justin Wood (:Callek)]

Attachment: Kill it off.

Requesting review from ted, as its mostly build-config related changes.

Ted if you feel we need/want the owners/peers of the touched code to chime in with an official review, can you either set[?] it or I can, just let me know in the bug here.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 468917 [details] [diff] [review]
Kill it off.

Pretty mechanical changes, I don't think they really require peer review for all the affected modules.

>diff --git a/js/src/xpconnect/src/Makefile.in b/js/src/xpconnect/src/Makefile.in
>--- a/js/src/xpconnect/src/Makefile.in
>+++ b/js/src/xpconnect/src/Makefile.in
>@@ -134,13 +134,8 @@
> 		$(MOZ_JS_LIBS) \
> 		$(NULL)
> 
>-ifdef MOZ_JSLOADER
> SHARED_LIBRARY_LIBS = \
> 		../loader/$(LIB_PREFIX)jsloader_s.$(LIB_SUFFIX) \
>-		$(NULL)
>-endif
>-
>-SHARED_LIBRARY_LIBS += \
> 		../wrappers/$(LIB_PREFIX)xpcwrappers_s.$(LIB_SUFFIX) \
> 		$(NULL)

While you're here, reformat this to be a two-space indent in the line continuations?

Comment 4

[Justin Wood (:Callek)]

Attachment: For checkin

Updated patch, for checkin

Comment 5

[Benjamin Smedberg]

Let's wait until after we branch.

Comment 6

[Justin Wood (:Callek)]

http://hg.mozilla.org/projects/build-system/rev/27163c3a66d2

Had to unbitrot slightly.

Comment 7

[Justin Wood (:Callek)]

Had a bustage due to a bad rebase, burned Android; pushed: http://hg.mozilla.org/projects/build-system/rev/397b3485b344

Note for verified-in-bs [once mxr updates],

http://mxr.mozilla.org/projects-central/search?string=MOZ_VIEW_SOURCE&find=%2Fbuild-system%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=projects-central
http://mxr.mozilla.org/projects-central/search?string=MOZ_JSLOADER&find=%2Fbuild-system%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=projects-central

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/27163c3a66d2
http://hg.mozilla.org/mozilla-central/rev/397b3485b344