Closed Bug 589506 Opened 10 years ago Closed 9 years ago

Scrub the codebase of MOZ_VIEW_SOURCE and MOZ_JSLOADER

Categories

(Toolkit :: View Source, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file, 1 obsolete file)

(In reply to Bug 513924 comment #17)
> Comment on attachment 399009 [details] [diff] [review] [details]
> Patch v1.1
> 
>  if test "$MOZ_VIEW_SOURCE"; then
>      AC_DEFINE(MOZ_VIEW_SOURCE)
>  fi
> 
> Feels like we could just remove this completely and scrub the codebase. I'm
> fine with doing it in a followup, though.

MOZ_VIEW_SOURCE is defined everywhere now, lets kill off this define entirely
I'll also tackle MOZ_JSLOADER in this bug.
Summary: Scrub the codebase of MOZ_VIEW_SOURCE → Scrub the codebase of MOZ_VIEW_SOURCE and MOZ_JSLOADER
Version: unspecified → Trunk
Attached patch Kill it off. (obsolete) — Splinter Review
Requesting review from ted, as its mostly build-config related changes.

Ted if you feel we need/want the owners/peers of the touched code to chime in with an official review, can you either set[?] it or I can, just let me know in the bug here.
Attachment #468917 - Flags: review?(ted.mielczarek)
Comment on attachment 468917 [details] [diff] [review]
Kill it off.

Pretty mechanical changes, I don't think they really require peer review for all the affected modules.

>diff --git a/js/src/xpconnect/src/Makefile.in b/js/src/xpconnect/src/Makefile.in
>--- a/js/src/xpconnect/src/Makefile.in
>+++ b/js/src/xpconnect/src/Makefile.in
>@@ -134,13 +134,8 @@
> 		$(MOZ_JS_LIBS) \
> 		$(NULL)
> 
>-ifdef MOZ_JSLOADER
> SHARED_LIBRARY_LIBS = \
> 		../loader/$(LIB_PREFIX)jsloader_s.$(LIB_SUFFIX) \
>-		$(NULL)
>-endif
>-
>-SHARED_LIBRARY_LIBS += \
> 		../wrappers/$(LIB_PREFIX)xpcwrappers_s.$(LIB_SUFFIX) \
> 		$(NULL)

While you're here, reformat this to be a two-space indent in the line continuations?
Attachment #468917 - Flags: review?(ted.mielczarek) → review+
Attached patch For checkinSplinter Review
Updated patch, for checkin
Attachment #468917 - Attachment is obsolete: true
Attachment #472559 - Flags: review+
Attachment #472559 - Flags: approval2.0?
Attachment #472559 - Flags: approval2.0? → approval2.0-
Let's wait until after we branch.
http://hg.mozilla.org/projects/build-system/rev/27163c3a66d2

Had to unbitrot slightly.
Whiteboard: fixed-in-bs
You need to log in before you can comment on or make changes to this bug.