Closed Bug 589556 Opened 10 years ago Closed 9 years ago

Make SVGMotionSMILPathUtils::PathGenerator use SVGLength, not nsSVGLength2

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

We should make SVGMotionSMILPathUtils::PathGenerator use SVGLength, not nsSVGLength2. SVGLength is more flexible, and we can avoid casting away constness.
Attached patch patchSplinter Review
Attachment #468171 - Flags: review?(longsonr)
Attachment #468171 - Flags: review?(longsonr) → review+
Keywords: checkin-needed
patch lacks approval2.0
Keywords: checkin-needed
Comment on attachment 468171 [details] [diff] [review]
patch

Oops, yeah. Requesting approval. This is a trivial and safe patch that we might as well get in and close this bug.
Attachment #468171 - Flags: approval2.0?
Don't forget to land this Jonathan.
Thanks! I have it in my list.
Actually since the tree is quiet for once I pushed http://hg.mozilla.org/mozilla-central/rev/17fddebefbf0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.