Closed
Bug 589556
Opened 14 years ago
Closed 14 years ago
Make SVGMotionSMILPathUtils::PathGenerator use SVGLength, not nsSVGLength2
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
5.98 KB,
patch
|
longsonr
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
We should make SVGMotionSMILPathUtils::PathGenerator use SVGLength, not nsSVGLength2. SVGLength is more flexible, and we can avoid casting away constness.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #468171 -
Flags: review?(longsonr)
|
||
Updated•14 years ago
|
Attachment #468171 -
Flags: review?(longsonr) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 468171 [details] [diff] [review]
patch
Oops, yeah. Requesting approval. This is a trivial and safe patch that we might as well get in and close this bug.
Attachment #468171 -
Flags: approval2.0?
Attachment #468171 -
Flags: approval2.0? → approval2.0+
|
|
||
Comment 4•14 years ago
|
||
Don't forget to land this Jonathan.
|
|
Assignee | |
Comment 5•14 years ago
|
||
Thanks! I have it in my list.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Actually since the tree is quiet for once I pushed http://hg.mozilla.org/mozilla-central/rev/17fddebefbf0
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•